chore: update virtual hardware versions

[tenthirtyam]

Description

• Updates version to an int instead of a string.
• Adds a check in Prepare() to ensure the value is > the minimum.
• Updates the documentation in config.go.
• Adds constants for the minimum and default virtual hardware versions.

Important

• Minimum is now 13 instead of 9.
• Default is 19 instead of 9.

Refer to Broadcom KB 315655

Testing

packer-plugin-vmware on  chore/update-virtual-harware-versions
➜ go fmt ./... 

packer-plugin-vmware on  chore/update-virtual-harware-versions
➜ make generate
2024/06/30 14:52:08 Copying "docs" to ".docs/"
2024/06/30 14:52:08 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  chore/update-virtual-harware-versions
➜ make build   

packer-plugin-vmware on  chore/update-virtual-harware-versions
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.598s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.811s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    2.122s

packer-plugin-vmware on  chore/update-virtual-harware-versions
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_arm64

Tested on:

• macOS 14.5 with VMware Fusion 13.5 (MacBook Pro M2 Max)
• Windows 11 22H2 with VMware Workstation 17.5 (Dell OptiPlex 7050 i7)

The virtual machines were able to boot with and without configuration of the version.

.vmx results for the default:

virtualhw.productcompatibility = "hosted"
virtualhw.version = "19"
vmci0.id = "1861462627"

Reference

• Broadcom KB 315655

[nywilken]

LGTM

[nywilken]

@tenthirtyam the change looks good overall but needs a rebase.

[tenthirtyam]

@tenthirtyam the change looks good overall but needs a rebase.

I'm on it!

[tenthirtyam]

@tenthirtyam the change looks good overall but needs a rebase.

Ready! ✅