Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golangci.yml #214

Merged
merged 1 commit into from
Jul 5, 2024
Merged

chore: update golangci.yml #214

merged 1 commit into from
Jul 5, 2024

Conversation

tenthirtyam
Copy link
Collaborator

Description

  • Removes the use of the following linters: 'deadcode' and 'varcheck'. Each are deprecated as of golangci-lint v1.49.0. The owners seem to have abandoned these linters and they are replaced by unused.
  • Updates deprecated configurations and removes redundant or default settings.
  • Removed fast: true under linters since it's not necessary when disable-all is used and specific linters are explicitly enabled.
  • Removed max-issues-per-linter and max-same-issues under issues to simplify the configuration, assuming default values are acceptable. If specific limits are needed, these can be added back with specific values.
  • Consolidated exclude-functions syntax for clarity.

Before:

packer-plugin-vmware on chore/update-golangci
➜ golangci-lint run
WARN [config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`. 
WARN [config_reader] The configuration option `output.format` is deprecated, please use `output.formats` 
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. 
WARN The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. 
WARN The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. 
ERRO [linters_context] deadcode: This linter is fully inactivated: it will not produce any reports. 
ERRO [linters_context] varcheck: This linter is fully inactivated: it will not produce any reports. 

After:

packer-plugin-vmware on chore/update-golangci
➜ golangci-lint run

packer-plugin-vmware on chore/update-golangci

Removes the use of the following linters: 'deadcode'  and 'varcheck'.

Both are deprecated as of `golangci-lint` v1.49.0. The owners seem to have abandoned these linters and they are replaced by `unused`.

Updates deprecated configurations and removes redundant or default settings.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam added this to the v1.0.12 milestone Jul 2, 2024
@tenthirtyam tenthirtyam self-assigned this Jul 2, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner July 2, 2024 22:53
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@nywilken nywilken merged commit 04f670f into main Jul 5, 2024
12 checks passed
@nywilken nywilken deleted the chore/update-golangci branch July 5, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants