chore: deprecate ssh_skip_request_pty

[tenthirtyam]

Description

Deprecate ssh_skip_request_pty per comment:

packer-plugin-vmware/builder/vmware/common/ssh_config.go

Lines 13 to 19 in 330dc55

	type SSHConfig struct {
	Comm communicator.Config `mapstructure:",squash"`
	// These are deprecated, but we keep them around for BC
	// TODO(@mitchellh): remove
	SSHSkipRequestPty bool `mapstructure:"ssh_skip_request_pty"`
	}

Testing

packer-plugin-vmware on  chore/remove-ssh_skip_request_pty [$!] via 🐹 v1.22.5 
⇣7% ➜ go fmt ./... 

packer-plugin-vmware on  chore/remove-ssh_skip_request_pty [$!] via 🐹 v1.22.5 
⇣7% ➜ make generate
2024/07/07 22:12:12 Copying "docs" to ".docs/"
2024/07/07 22:12:12 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  chore/remove-ssh_skip_request_pty [$!] via 🐹 v1.22.5 
⇣7% ➜ make build   

packer-plugin-vmware on  chore/remove-ssh_skip_request_pty [$!] via 🐹 v1.22.5 took 3.2s 
⇣7% ➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.603s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    2.159s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    1.716s

[nywilken]

So this change requires a minor bump. When we remove configuration options that have been deprecated a minor is used to finalize the remove. Please let me know if you have any objections.

[nywilken]

This looks good to me. I am approving but will hold on the merge until I get the okay since this needs to be released in a minor version.

[tenthirtyam]

Yep! I have this and the others all under the v1.1.0 milestone - we'll need to bump version.go.

[tenthirtyam]

I've updated this to simply add a deprecation warning and that it will be removed in the next major. cc @nywilken @lbajolet-hashicorp

[lbajolet-hashicorp]

Overall LGTM! I left a comment regarding the removal of c.Comm.SSHPty = false, just out of an abundance of precaution here, feel free to respond when you have time.

Pre-approving to not delay a future merge, since it's a minor concern, and whatever resolution will be good imo.