-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: consolidate player driver #231
Conversation
5a828c6
to
82753c2
Compare
8455cd4
to
56e5c45
Compare
bd0479a
to
537d592
Compare
@lbajolet-hashicorp - this one is ready for initial review for the driver consolidation. E2E testing is still pending but I will be testing it this week on both Windows (11) and Linux (Ubuntu 22.04) with Workstation Player 17.6. Ryan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple nits, but overall this LGTM, thanks @tenthirtyam!
Pre-approving now, we can merge once you've had a chance to address my comments
537d592
to
5b336cb
Compare
5b336cb
to
7229c55
Compare
Consolidates `Player5Driver` and `Player6Driver` to `PlayerDriver` within `driver_player.go`. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
7229c55
to
ca282ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the rerolls @tenthirtyam
Merging now!
Description
Consolidates
Player5Driver
andPlayer6Driver
toPlayerDriver
withindriver_player.go
.Testing