Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 refactor: consolidate workstation driver #232

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🚧 refactor: consolidate workstation driver #232

wants to merge 1 commit into from

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Jul 19, 2024 •
edited
Loading

Description

🚧 WORK IN PROGRESS 🚧

  • Consolidates Workstation9Driver and Workstation10Driver to WorkstationrDriver within driver_workstation.go.
  • Addresses the deprecation of syscall.StringToUTF16Ptr with windows.UTF16PtrFromString in readRegString.

Testing

  • Basic
  • End-to-End
packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 
➜ go fmt ./...

packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 
➜ make generate
2024/07/18 22:39:16 Copying "docs" to ".docs/"
2024/07/18 22:39:16 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 took 3.2s 
➜ make build  

packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 took 3.6s 
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.705s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.995s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    2.467s

packer-plugin-vmware on  refactor/consolidate-workstation-driver [$] via 🐹 v1.22.5 took 10.5s 
➜ make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_arm64

@tenthirtyam tenthirtyam added this to the v1.1.1 milestone Jul 19, 2024
@tenthirtyam tenthirtyam self-assigned this Jul 19, 2024
@tenthirtyam tenthirtyam force-pushed the refactor/consolidate-workstation-driver branch 2 times, most recently from 5cafb40 to d7e0e36 Compare August 9, 2024 18:20
@tenthirtyam tenthirtyam marked this pull request as ready for review August 10, 2024 03:42
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 10, 2024 03:42
@tenthirtyam tenthirtyam marked this pull request as draft August 26, 2024 15:58
@tenthirtyam tenthirtyam force-pushed the refactor/consolidate-workstation-driver branch 2 times, most recently from 789045f to 1af8586 Compare September 10, 2024 02:01
@tenthirtyam tenthirtyam force-pushed the refactor/consolidate-workstation-driver branch from 1af8586 to cb66913 Compare December 4, 2024 19:02
@tenthirtyam tenthirtyam changed the title refactor: consolidate workstation driver 🚧 refactor: consolidate workstation driver Dec 4, 2024
@tenthirtyam tenthirtyam force-pushed the refactor/consolidate-workstation-driver branch 4 times, most recently from 4d585c5 to 83f813e Compare December 5, 2024 21:07
@tenthirtyam
Copy link
Collaborator Author

Will start the e2e testing tomorrow now that alls clearing after the rebase + fixups.

Getting there!

@tenthirtyam tenthirtyam force-pushed the refactor/consolidate-workstation-driver branch 7 times, most recently from e5d0698 to 5a339b7 Compare December 7, 2024 20:12
@tenthirtyam
refactor: consolidate workstation driver
fec4960 
- Consolidates `Workstation9Driver` and `Workstation10Driver` to `WorkstationrDriver` within `driver_workstation.go`.
- Addresses  the deprecation of `syscall.StringToUTF16Ptr` with `windows.UTF16PtrFromString` in `readRegString`.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the refactor/consolidate-workstation-driver branch from 5a339b7 to fec4960 Compare December 7, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tenthirtyam tenthirtyam

Labels
hypervisor/workstation VMware Workstation tech-debt
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.
1 participant
@tenthirtyam