azr
released this
18 Aug 12:40
Fix handling of temporary cdrom devices (#31)
* Track cdrom in temporaryDevices for step_clean_vmx
There was a previous attempt to do this in step_configure_vmx,
but that only covers vmware-iso (missing potential cases when using
cd_files/cd_content in vmware-vmx) and it had the wrong device name
(would mark <type>0:<primary> as temporary when the device name used
for cd_path is actually <type>1:<primary>
* Fix overwriting an existing cdrom device
ParseVMX/EncodeVMX force the keys to lowercase, so inserting with a
mixed-case key fails to replace existing values, resulting in duplicate
lines and vmware potentially still using the previous filename
* Generalize SkipFloppy to SkipDevices
It's not just floppies, it doesn't make sense to create any new
temporaryDevices in between StepCleanFiles and StepCleanVMX.