Skip to content

Conversation

@tenthirtyam
Copy link
Collaborator

Description

Adds support for specifying a datastore_cluster (in addition to the existing datastore option) for virtual machine builds and post-processing. It ensures that datastore and datastore_cluster are mutually exclusive, updates documentation, and adjusts the build logic to handle Storage DRS recommendations for multi-disk VMs. Several steps in the build and upload process are updated to respect the resolved datastore selection.

Configuration and Validation Updates:

  • Added datastore_cluster as a configuration option in builder and post-processor config structs, with validation to ensure only one of datastore or datastore_cluster is specified. [1] [2] [3] [4] [5] [6]

Documentation Improvements:

  • Updated documentation for vsphere-clone, vsphere-iso, and vsphere post-processor components to describe the new datastore_cluster option, its mutual exclusivity with datastore, and Storage DRS behavior. [1] [2] [3] [4]

Build and Clone Logic Enhancements:

  • Modified the VM cloning step to support disk placement recommendations from Storage DRS when a datastore_cluster is specified, including handling for multiple disks and fallback logic. [1] [2] [3] [4]
  • Added a step to resolve the datastore or datastore cluster before VM creation.

Upload and Cleanup Step Adjustments:

  • Updated steps for uploading and deleting files (floppy, ISO, CD, and remote cache) to use the resolved datastore from either datastore or datastore_cluster throughout the build and cleanup process. (F1d22be6L35R35, [1] [2] [3] [4] [5] [6] [7] [8]

Resolved Issues

Adds support for the use of datastore clusters in the applicable builders and post-processors.

Closes #9

Rollback Plan

Revert commit.

Changes to Security Controls

None.

@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Oct 17, 2025
@tenthirtyam tenthirtyam self-assigned this Oct 17, 2025
@tenthirtyam tenthirtyam force-pushed the feat/datastore-clusters branch from 6a7cad1 to 2f939ee Compare October 17, 2025 13:51
Adds support for the use of datastore clusters in the applicable builders and post-processors.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the feat/datastore-clusters branch from 2f939ee to a3f9c4d Compare November 26, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for datastore cluster storage

1 participant