feat: add support for datastore clusters #574
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for specifying a
datastore_cluster(in addition to the existingdatastoreoption) for virtual machine builds and post-processing. It ensures thatdatastoreanddatastore_clusterare mutually exclusive, updates documentation, and adjusts the build logic to handle Storage DRS recommendations for multi-disk VMs. Several steps in the build and upload process are updated to respect the resolved datastore selection.Configuration and Validation Updates:
datastore_clusteras a configuration option in builder and post-processor config structs, with validation to ensure only one ofdatastoreordatastore_clusteris specified. [1] [2] [3] [4] [5] [6]Documentation Improvements:
vsphere-clone,vsphere-iso, andvspherepost-processor components to describe the newdatastore_clusteroption, its mutual exclusivity withdatastore, and Storage DRS behavior. [1] [2] [3] [4]Build and Clone Logic Enhancements:
datastore_clusteris specified, including handling for multiple disks and fallback logic. [1] [2] [3] [4]Upload and Cleanup Step Adjustments:
datastoreordatastore_clusterthroughout the build and cleanup process. (F1d22be6L35R35, [1] [2] [3] [4] [5] [6] [7] [8]Resolved Issues
Adds support for the use of datastore clusters in the applicable builders and post-processors.
Closes #9
Rollback Plan
Revert commit.
Changes to Security Controls
None.