Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please, Upgrade armon/go-metrics to hashicorp/go-metrics #707

Open
peczenyj opened this issue Nov 8, 2023 · 2 comments · May be fixed by #735
Open

Please, Upgrade armon/go-metrics to hashicorp/go-metrics #707

peczenyj opened this issue Nov 8, 2023 · 2 comments · May be fixed by #735

Comments

@peczenyj
Copy link

peczenyj commented Nov 8, 2023

The package armon/go-metrics was renamed to hashicorp/go-metrics

however, I need to add replace directives in my go.mod files to keep the vendors updated.

can we just update the dependencies and release again?
@peczenyj peczenyj mentioned this issue Nov 8, 2023
Open
1 task
@peczenyj peczenyj changed the title Upgrade armon/go-metrics to hashicorp/go-metrics Please, Upgrade armon/go-metrics to hashicorp/go-metrics Nov 15, 2023
frebib added a commit to frebib/mgmt that referenced this issue Apr 28, 2024
@frebib
mod: Replace armon/go-metrics with hashicorp/go-metrics
c774f15 
Fixes the renamed-but-not-actually library that was moved into the
hashicorp org that causes failures when trying to update modules:

    $ go get -u
    go: github.com/armon/go-metrics@v0.5.3: parsing go.mod:
            module declares its path as: github.com/hashicorp/go-metrics
                    but was required as: github.com/armon/go-metrics
            trying github.com/armon/go-metrics@v0.5.2
    go: github.com/armon/go-metrics@v0.5.2: parsing go.mod:
            module declares its path as: github.com/hashicorp/go-metrics
                    but was required as: github.com/armon/go-metrics
            trying github.com/armon/go-metrics@v0.5.1
    go: github.com/armon/go-metrics@v0.5.1: parsing go.mod:
            module declares its path as: github.com/hashicorp/go-metrics
                    but was required as: github.com/armon/go-metrics
            trying github.com/armon/go-metrics@v0.5.0
    go: github.com/armon/go-metrics@v0.5.0: parsing go.mod:
            module declares its path as: github.com/hashicorp/go-metrics
                    but was required as: github.com/armon/go-metrics
            trying github.com/armon/go-metrics@v0.4.2
    go: github.com/armon/go-metrics@v0.4.2: parsing go.mod:
            module declares its path as: github.com/hashicorp/go-metrics
                    but was required as: github.com/armon/go-metrics
            restoring github.com/armon/go-metrics@v0.4.1

This is a workaround until hashicorp/serf#707
is fixed.

Signed-off-by: Joe Groocock <me@frebib.net>
@Dentrax
Copy link

Dentrax commented Jul 28, 2024 •
edited
Loading

Just hit this issue. I was wondering if there are any updates on this?

cc @badrabubker

Dentrax added a commit to Dentrax/serf that referenced this issue Jul 28, 2024
@Dentrax
Upgrade armon/go-metrics to hashicorp/go-metrics
a14471e 
Fixes hashicorp#707

Signed-off-by: Dentrax <furkan.turkal@hotmail.com>
@Dentrax Dentrax linked a pull request Jul 28, 2024 that will close this issue
Open
@rboyer
Copy link
Member

rboyer commented Jul 29, 2024

Quoting @jmurret's reply on a related PR:

Hi all, we will post a more detailed thread on why this is complicated, but the short gist is that this change has to be consistently updated across the dependency chains of libraries used in an application. go-metrics relies on a singleton sink in global state. If any applications have a mix of armon metrics and hashicorp due to underlying dependencies not aligning on only one of them, metrics will be split among different sinks in the global state.
This change has to be coordinated with changing and releasing this dependency across multiple libraries and applications in a thoughtful way. This PR is taking longer than expected due to the prioritization and coordination of those efforts to ensure a smooth transition. Thank you for your patience and understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade armon/go-metrics to hashicorp/go-metrics Dentrax/serf
3 participants
@rboyer @peczenyj @Dentrax