Upgrade armon/go-metrics to hashicorp/go-metrics

[mkeeler]

Also bumping hashicorp/memberlist to the corresponding version which also uses hashicorp/go-metrics

This will require a new major version to signify that metrics are using different global handlers.

TODO:

• Merge Upgrade armon/go-metrics to hashicorp/go-metrics memberlist#287 and pull in the new memberlist version

[puffpuf]

can someone merge it, please?

[peczenyj]

+1 here

I need to the line below several go.mod files and it is annoying

replace github.com/armon/go-metrics v0.5.1 => github.com/hashicorp/go-metrics v0.5.1

[peczenyj]

fix issue #707

[alex-savin]

+1 here

[peczenyj]

any reason to not merge it ?

[adamrothman]

@mkeeler @hashi-derek can we get some 👀 on this?

[frebib]

Bump please; without this patch, this library is completely unusable/broken for anyone using it, or pulling in something that uses it

[shane-ns1]

Wow this PR is more than a year old! Is the repository completely unmaintained? 😬

[peczenyj]

@shane-ns1 looks like ...

[peczenyj]

perhaps we should start to ping @dhiaayachi and other people that can merge on this repo

[shane-ns1]

perhaps we should start to ping @dhiaayachi and other people that can merge on this repo

Or even @armon? 😆

[jmurret]

Hi all, we will post a more detailed thread on why this is complicated, but the short gist is that this change has to be consistently updated across the dependency chains of libraries used in an application. go-metrics relies on a singleton sink in global state. If any applications have a mix of armon metrics and hashicorp due to underlying dependencies not aligning on only one of them, metrics will be split among different sinks in the global state.
This change has to be coordinated with changing and releasing this dependency across multiple libraries and applications in a thoughtful way. This PR is taking longer than expected due to the prioritization and coordination of those efforts to ensure a smooth transition. Thank you for your patience and understanding.