Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Primary Key Retrieval Command #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vladfau
Copy link

@vladfau vladfau commented Feb 15, 2020

Hi guys,

Initially, I had a requirement for Consul to obtain the currently used primary encryption key, but it looks like I've gotta start from Serf first. Please let me know what do you think about this approach and do you find it useful at all? I can add tests for UI part later on if you consider it a right way to achieve my original task.

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 15, 2020

CLA assistant check
All committers have signed the CLA.

@hanshasselberg
Copy link
Member

@vladfau thank you very much for your contribution. When I read the headline I expected that the code would return the primary key of the local node, but it is asking every node for their primary keys.

I am curious about the use case for such an operation, could you explain what you would want to do with this operation?

@vladfau
Copy link
Author

vladfau commented Mar 11, 2020

@i0rek, thanks for replying to my PR!

My idea here was simple – mimic the behavior of ListKeys(), but only retrieve the primary one only as I was unable to identify the way how to request this key from the current member. Also, I do not think that we can avoid querying all the members for CLI-based calls, when the caller is not member of the cluster (basing on what I understand in Serf).

@kyhavlov
Copy link
Contributor

Hi @vladfau - you mentioned the motivation here was to obtain the current primary key in Consul - are you looking for something similar to the existing -list or -list-primary flags under the keyring command? https://www.consul.io/commands/keyring#list-primary

@vladfau
Copy link
Author

vladfau commented Aug 15, 2021

Hello @kyhavlov,

I am no longer working with this project. I can say that if -list-primary returns the current primary key and it is always returns the active primary one without any permutations, this PR can be closed

@jen20 jen20 removed their request for review September 7, 2021 21:31
@hanshasselberg hanshasselberg removed their assignment Nov 11, 2022
@hanshasselberg hanshasselberg removed their request for review November 28, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants