Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance mDNS Functionality #733

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Enhance mDNS Functionality #733

merged 3 commits into from
Jul 8, 2024

Conversation

badrabubker
Copy link
Contributor

This PR:

  • Allows specifying iface for mDNS: In our use case, we disable multicast on the interface that Serf binds to. However, we have another network where Serf can discover neighbors using multicast.
  • Updates mDNS to v1.0.5: mDNS v1.0.5 enables the disabling of one of the IP stacks.
  • Allows disabling one of the IP stacks in the config file and CLI arguments.

@badrabubker badrabubker requested a review from a team as a code owner July 2, 2024 19:15
@badrabubker badrabubker requested review from DanStough and removed request for a team July 2, 2024 19:15
Copy link

hashicorp-cla-app bot commented Jul 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I had some really minor comments we can address before merging.

cmd/serf/command/agent/config.go Outdated Show resolved Hide resolved
cmd/serf/command/agent/command.go Show resolved Hide resolved
cmd/serf/command/agent/command.go Show resolved Hide resolved
v1.0.5 allows disable ipv4 or ipv6 when binding to an interface to query
allow the user to disable v4 or v6 if needed. This solves the issue when
a user is using discover option but having only one IP stack
Copy link
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 . I'll wait for the checks to pass before merging.

@DanStough DanStough merged commit af974b8 into hashicorp:master Jul 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants