Fix exitcode bug introduced in PR/125 #429
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #125 any terraform exit code of
2
will be considered passing even when it is a valid failure.For example,
terraform fmt
can return 0, 2, or 3. (see https://github.com/hashicorp/terraform/blob/v1.9.3/internal/command/fmt.go#L96 )The proposed solution in this PR is to verify that
-detailed-exitcode
argument was passed in. Additional test scenarios were added to cover the original pull request and this change.