Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

changes launch configuration to launch template #176

Closed
wants to merge 1 commit into from

Conversation

acsrujan
Copy link

No description provided.

@hashicorp-cla
Copy link

hashicorp-cla commented May 28, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple worries:

  1. This is a very backwards incompatible change... And I'm not seeing a migration path here other than "undeploy your entire cluser and redeploy based on launch templates." We'd need to think through how existing users would be able to upgrade without downtime.

  2. Is there anything a launch config can do that a launch template can't? I know we gain some features with launch templates, but are we losing any?

@acsrujan
Copy link
Author

acsrujan commented Jun 1, 2020

Hey,

  1. Yes. I left it in draft version for work in progress. I'll close it and raise one when it's ready with backward compatible version (if feasible).
    Upgrade without downtime is not yet addressed. I'm considering if we create launch template, attach it to existing ASG. Still working on making it frictionless.
    This might require a discussion here or Feature Request: Support Launch-Templates for t2/t3 unlimited configuration #103

  2. No, both from official documentation and personal experience.

@acsrujan acsrujan closed this Jun 1, 2020
@acsrujan acsrujan deleted the patch-1 branch June 1, 2020 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants