Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Fixes #185 AWS S3 Presigned url not working for download-url #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #185 AWS S3 Presigned url not working for download-url #187

wants to merge 1 commit into from

Conversation

mabadillamycwt
Copy link

Add single quote on example to avoid escape/encoding

@mabadillamycwt
Fixes hashicorp#185
2c36348 
Add single quote example to avoid escape/encoding
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

brikis98
brikis98 reviewed Feb 26, 2020
View reviewed changes
Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you sign the CLA?

brikis98
brikis98 reviewed Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you for your patience! We merged fixes in #195. Could you rebase? I can then kick off tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brikis98 brikis98 brikis98 left review comments

@Etiene Etiene Awaiting requested review from Etiene

@robmorgan robmorgan Awaiting requested review from robmorgan robmorgan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabadillamycwt @hashicorp-cla @brikis98