This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Pull request to fix #191 #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…documentation fixes
…documentation fixes
…documentation fixes
…documentation fixes
…documentation fixes
|
|
brikis98
approved these changes
Apr 3, 2020
|
Hm, many of the tests failed: From what I can see, it's able to build the AMI and run It basically is looking for a 501 over and over again and never getting it. Could you run one of these examples and see what the issue is? |
|
These tests are pretty slick. I think I've got things set up to run them locally now. I'll give it a shot and report my findings. |
|
@brikis98 I was able to recreate these errors with my branch, but not being able to connect any dots, I tried to run the entire suite against the master branch I forked -- i.e. without my commits -- and got the same errors. I think some of them are failing because I don't have autoseal keys setup, but I'm definitely seeing the 501 error in there as well. Another interesting thing is if I pick one of the failing tests (that don't use autoseal) and target it individually with I don't know if that means there's a race condition in the failing tests or something to do with running all the tests in parallel? Is there a way you can trigger the circleci tests against master and see if I'm looking at things correctly that the issue is upstream from my branch? |
|
Thanks for taking a look! I'll try to dig in this week to see if things are working on |
|
There are indeed some issues on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the --agent-ca-cert-file flag leaving handling of the typo in place for backward compatibility.
I also noticed another typo in the documentation
--dynamo--tablethat is fixed here as well. This one was just an echo bug, so it didn't seem necessary to try to handle the typo.https://github.com/hashicorp/terraform-aws-vault/blob/master/modules/run-vault/run-vault#L48
I also noticed the README.md was out of date with the new flags, so did my best to update that documentation accordingly.
I don't think there are any unit tests that apply here so I didn't run anything, but I did test the script for backward compatibility in my environment and both versions of the flag worked as expected.