This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Add option to use_existing_s3_bucket instead of creating one. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just checking, did I create this pull request correctly? It relates to the enhancement suggestion - #236 |
|
I'm wondering what other needs might need to be met for this to be approved? |
|
Is anything preventing this from being merged? |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If var.use_existing_s3_bucket is true, will acquire the bucket id and arn by the provided var.s3_bucket_name instead of creating a new bucket in this module. This allows a user to avoid creating and destroying the S3 bucket repeatedly, and they can persist configuration from the s3 backend even after destroying this module.