Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix path error #494

Merged
merged 1 commit into from
Oct 26, 2023
Merged

chore: Fix path error #494

merged 1 commit into from
Oct 26, 2023

Conversation

moduli
Copy link
Contributor

@moduli moduli commented Oct 25, 2023

I was running into the following error when running make test-database-up

❯ make test-database-up
Using image:                       docker.io/hashicorpboundary/postgres:11-alpine
Additional postgres configuration: 
Using volume:                      ~/go/pkg/mod/github.com/hashicorp/boundary@v0.13.1-0.20231012004550-1ed0a13004b9/internal/db/schema/migrations:/migrations
docker: Error response from daemon: create ~/go/pkg/mod/github.com/hashicorp/boundary@v0.13.1-0.20231012004550-1ed0a13004b9/internal/db/schema/migrations: "~/go/pkg/mod/github.com/hashicorp/boundary@v0.13.1-0.20231012004550-1ed0a13004b9/internal/db/schema/migrations" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
See 'docker run --help'.
make: *** [test-database-up] Error 125

The error seems to point to the formatting of the volume that was passed in. This PR updates the makefile to use an absolute path instead.

@moduli moduli marked this pull request as ready for review October 25, 2023 18:57
@louisruch
Copy link
Contributor

Ill ask @tmessi for a review on this

@louisruch louisruch requested a review from tmessi October 26, 2023 05:28
@moduli moduli merged commit 34dbe45 into main Oct 26, 2023
7 checks passed
@moduli moduli deleted the moduli-makefile-fix branch October 26, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants