Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HVT-6147: Fix and enable vault acceptance tests #1218

Merged
merged 24 commits into from
Feb 20, 2025
Merged

Conversation

chirags101
Copy link
Contributor

@chirags101 chirags101 commented Feb 17, 2025

Enabling failing tests TestAcc_Vault_ClusterAWS and TestAcc_Vault_PerformanceReplication_ValidationsAws

TestAcc_Vault_ClusterAWS encountered failures while updating the cluster tier and public/proxy settings. During the upgrade, only the cluster tier was updated, while the publicIP/proxy configuration remained was not updated (admin/UI and update cadence WF input as well) which seems like a potential bug or missout.

TestAcc_Vault_PerformanceReplication_ValidationsAws :

  • The hcpv-observability-http LD flag was enabled for the integration environment to allow HTTP audit log streaming.
  • Resource validation for audit_log_config was failing which was fixed by doing indentation for audit_log_config set for resource
  • In one of the test steps, the cluster configuration was changed from DEV to PLUS_SMALL, which is not permitted in the cloud-vault-service; it has now been updated to STANDARD_SMALL.

Jira: https://hashicorp.atlassian.net/browse/HVT-6147

Jira to track publicIP/proxy + tier modification bug: https://hashicorp.atlassian.net/browse/HVT-6463

🛠️ Description

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Copy link

hashicorp-cla-app bot commented Feb 17, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@chirags101 chirags101 changed the title DoNotMerge: Enable vault acceptance tests HVT-6147: Fix and enable vault acceptance tests Feb 20, 2025
@chirags101 chirags101 marked this pull request as ready for review February 20, 2025 04:43
@chirags101 chirags101 requested review from a team as code owners February 20, 2025 04:43
Copy link
Member

@jasonpilz jasonpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a ton for doing this!

@chirags101 chirags101 merged commit 2a7a6c2 into main Feb 20, 2025
8 checks passed
@chirags101 chirags101 deleted the vault/acceptance_tests branch February 20, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants