Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasource/tls_certificate: Update www.terraform.io testing for certificate change #524

Merged
merged 1 commit into from
May 28, 2024

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 28, 2024

Closes #523

This change updates the value testing of www.terraform.io certificates to match the updated certificate chain. This testing is important for verifying the behavior of the data source with real world information, such as ensuring Go version or dependency upgrades do not introduce unexpected regressions.

…ficate change

Reference: #523

This change updates the value testing of www.terraform.io certificates to match the updated certificate chain. This testing is important for verifying the behavior of the data source with real world information, such as ensuring Go version or dependency upgrades do not introduce unexpected regressions.
@bflad bflad requested a review from a team as a code owner May 28, 2024 20:03
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🎸

@bflad bflad merged commit a35399a into main May 28, 2024
44 of 45 checks passed
@bflad bflad deleted the bflad/terraform-io-ssl-rollover branch May 28, 2024 20:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data/tls_certificate: Updating real world testing for new www.terraform.io certificate results
2 participants