PSS : Add fs and inmem state storage implementations to the builtin simplev6 provider, update grpcwrap package, use PSS implementation in E2E test
#37790
+1,250
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
SarahFrench
commented
Oct 20, 2025
SarahFrench
changed the title
inmem state storage implementation to the builtin terraform providerinmem state storage implementation to the builtin terraform provider, update grpcwrap package, use PSS implementation in E2E test
SarahFrench
force-pushed
the
pss/add-builtin-inmem-state-storage-implementation
branch
from
a4887d9 to
ef6dc39
Compare
SarahFrench
commented
Oct 24, 2025
.github/workflows/checks.yml
Outdated
Comment on lines
110
to
111
| run: | | ||
| TF_ACC=1 go test -v ./internal/command/e2etest | ||
| TF_TEST_EXPERIMENT=1 TF_ACC=1 go test -v ./internal/command/e2etest |
Member
Author
There was a problem hiding this comment.
Something to bear in mind is that E2E tests also run in the context of the build workflow. I think it'd best to avoid enabling experiments to leak to that workflow, and instead have experimental tests skipped when running in that context.
SarahFrench
force-pushed
the
pss/add-builtin-inmem-state-storage-implementation
branch
2 times, most recently
from
0f01ff6 to
2fadb1e
Compare
SarahFrench
changed the title
inmem state storage implementation to the builtin terraform provider, update grpcwrap package, use PSS implementation in E2E testfs and inmem state storage implementationd to the builtin simplev6 provider, update grpcwrap package, use PSS implementation in E2E test
SarahFrench
force-pushed
the
pss/add-builtin-inmem-state-storage-implementation
branch
from
727ae19 to
8f77b19
Compare
…tations, pass through requests to matching store based on type name.
… implementation; add embeddable unimplementedProviderInterface struct
…orm provider. Stop people using it unless TF_ACC is set.
…pace state already.
…n terraform provider
…they can be reused.
…ther work to allow PSS to be used with other commands.
This provider is not accessible to users so it's unnecessary.
Seeing as I was in this part of the code during this branch's work
SarahFrench
commented
Nov 6, 2025
Comment on lines
+108
to
+110
| Capabilities: providers.StateStoreClientCapabilities{ | ||
| ChunkSize: DefaultStateStoreChunkSize, | ||
| }, |
Member
Author
There was a problem hiding this comment.
I realised that we never sent the default chunk size data from Core to the provider at the start of chunk size negotiation 😬
SarahFrench
force-pushed
the
pss/add-builtin-inmem-state-storage-implementation
branch
from
8f77b19 to
316d5b5
Compare
SarahFrench
changed the title
fs and inmem state storage implementationd to the builtin simplev6 provider, update grpcwrap package, use PSS implementation in E2E testfs and inmem state storage implementations to the builtin simplev6 provider, update grpcwrap package, use PSS implementation in E2E test
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables E2E testing with pluggable state storage:
grpcwrappackage, which is needed to allow provider-like code in Core to behave like it's a real separate provider plugin.inmemandfsstate store in the v6 version ofterraform-provider-simpleTarget Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry