Implement equality for state objects #37886
Merged
+249
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
force-pushed
the
jbardin/state-deep-equal
branch
3 times, most recently
from
f14c727 to
2cc3aec
Compare
Contributor
|
The equivalence tests will be updated. Please verify the changes here. |
jbardin
force-pushed
the
jbardin/state-deep-equal
branch
from
2cc3aec to
ae8bfe2
Compare
the use of reflect.DeepEqual fails for states, because they contain value which cannot be directly compared for equality. The Equal method is not used much, except to aid in backend migration, so the failure there was rarely noticed. The failure of ManagedResourcesEqual would show up in the CLI after Terraform reported there were no changes, by exiting with a non-zero code because the resource states incorrectly reported as being changed.
jbardin
force-pushed
the
jbardin/state-deep-equal
branch
from
ae8bfe2 to
f78c64e
Compare
Contributor
|
The equivalence tests will be updated. Please verify the changes here. |
Contributor
|
The equivalence tests will be updated. Please verify the changes here. |
mildwonkey
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State was using
reflect.DeepEqualfor comparison, but the state objects could contain values which cannot be compared using that method. Implement equality methods for each of the state objects.These comparison are not used in any critical codepaths, but do show up in unexpected places, like backend migrations which don't appear to be needed, or incorrect exit codes when there are no changes planned.
Fixes #37406
Target Release
1.15.x