-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cd-356: add simplecov gem #141
Commits on Oct 2, 2018
-
Sasha Gerrand committed
Oct 2, 2018 Configuration menu - View commit details
-
Copy full SHA for 27578df - Browse repository at this point
Copy the full SHA 27578dfView commit details -
Publish pre-release gem versions to JFrog
Sasha Gerrand committedOct 2, 2018 Configuration menu - View commit details
-
Copy full SHA for 831f397 - Browse repository at this point
Copy the full SHA 831f397View commit details -
Sasha Gerrand committed
Oct 2, 2018 Configuration menu - View commit details
-
Copy full SHA for 5d32480 - Browse repository at this point
Copy the full SHA 5d32480View commit details -
* Fix configuration * Update Vault version * Add config so a new release is published when a tag is pushed to Github
Configuration menu - View commit details
-
Copy full SHA for ef7afb6 - Browse repository at this point
Copy the full SHA ef7afb6View commit details -
Merge pull request #3 from FundingCircle/circleci-publish-to-artifactory
Integrate CircleCI to run test suites and build and push gems to Artifactory
Configuration menu - View commit details
-
Copy full SHA for 70d06dd - Browse repository at this point
Copy the full SHA 70d06ddView commit details -
Require tests to pass for tagged releases
As a tag could potentially originate from any commit, run the test suite for any changes. They should pass prior to building and pushing a released gem.
Sasha Gerrand committedOct 2, 2018 Configuration menu - View commit details
-
Copy full SHA for 6f46db9 - Browse repository at this point
Copy the full SHA 6f46db9View commit details
Commits on Oct 4, 2018
-
Merge pull request #4 from FundingCircle/circleci-support-tags
CircleCI should support tags
Configuration menu - View commit details
-
Copy full SHA for 54b6047 - Browse repository at this point
Copy the full SHA 54b6047View commit details -
* Add git to publish-release in .circleci/config.yml for fix builds * Fix indentation in .circleci/config.yml
Configuration menu - View commit details
-
Copy full SHA for f3705db - Browse repository at this point
Copy the full SHA f3705dbView commit details -
Merge pull request #5 from FundingCircle/fix_circleci_tag_build
Fix tag builds on CircleCI
Configuration menu - View commit details
-
Copy full SHA for adaa035 - Browse repository at this point
Copy the full SHA adaa035View commit details -
Persist attributes before save
Persisting Vault attributes on an `after_save` uses two separate queries: one for the model `INSERT/UPDATE`, and another to `UPDATE` the ciphertext for the encrypted attributes. Encrypting the attributes with a `before_save` avoids the second query. In some cases users might _not_ want to have two queries when saving a single record. This would be necessary for example, when one has an auditing table and/or stored procedures that take some action when a record is changed.
Configuration menu - View commit details
-
Copy full SHA for ba2de1f - Browse repository at this point
Copy the full SHA ba2de1fView commit details -
Merge pull request #2 from FundingCircle/persist_before_save
Persist attributes before save
Configuration menu - View commit details
-
Copy full SHA for 95a1243 - Browse repository at this point
Copy the full SHA 95a1243View commit details
Commits on Oct 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7cac8c7 - Browse repository at this point
Copy the full SHA 7cac8c7View commit details
Commits on Oct 8, 2018
-
Merge pull request #6 from FundingCircle/serializers
Add serializers for Dates, Integers and Floats
Configuration menu - View commit details
-
Copy full SHA for 74002dc - Browse repository at this point
Copy the full SHA 74002dcView commit details
Commits on Oct 9, 2018
-
What does this PR do? --------------------- * Adds support for convergent encryption Where should the reviewer start? -------------------------------- * `lib/vault/rails.rb` * `lib/vault/encrypted_model.rb` Any background context you want to provide? ------------------------------------------- * Vault supports convergent encryption since v0.6.1, but this gem does not take advantage of this functionality.
Configuration menu - View commit details
-
Copy full SHA for f71550c - Browse repository at this point
Copy the full SHA f71550cView commit details -
Merge pull request #1 from FundingCircle/convergent_encryption
Convergent encryption support
Configuration menu - View commit details
-
Copy full SHA for fc715f2 - Browse repository at this point
Copy the full SHA fc715f2View commit details -
Only load the attributes that we need to when using vault_lazy_decrypt!
Configuration menu - View commit details
-
Copy full SHA for dc550ef - Browse repository at this point
Copy the full SHA dc550efView commit details -
Merge pull request #7 from FundingCircle/improve_lazy_decrypt
Improve lazy decrypt
Configuration menu - View commit details
-
Copy full SHA for 1edffd2 - Browse repository at this point
Copy the full SHA 1edffd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1013b6 - Browse repository at this point
Copy the full SHA d1013b6View commit details -
Merge pull request #8 from FundingCircle/update_readme
Update README.md
Configuration menu - View commit details
-
Copy full SHA for 85f19d3 - Browse repository at this point
Copy the full SHA 85f19d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9feedaa - Browse repository at this point
Copy the full SHA 9feedaaView commit details -
Merge pull request #9 from FundingCircle/bump_to_v0.5.0
Bump to v0.5.0
Configuration menu - View commit details
-
Copy full SHA for f0e6722 - Browse repository at this point
Copy the full SHA f0e6722View commit details
Commits on Oct 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 11b81b2 - Browse repository at this point
Copy the full SHA 11b81b2View commit details -
Merge pull request #10 from FundingCircle/rename_gem
Rename gem to fc-vault-rails.
Configuration menu - View commit details
-
Copy full SHA for 4473906 - Browse repository at this point
Copy the full SHA 4473906View commit details
Commits on Oct 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 09df960 - Browse repository at this point
Copy the full SHA 09df960View commit details -
Merge pull request #12 from FundingCircle/remove_rails_4_1
Remove Rails 4.1 dependency
Configuration menu - View commit details
-
Copy full SHA for cb72242 - Browse repository at this point
Copy the full SHA cb72242View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd5e604 - Browse repository at this point
Copy the full SHA fd5e604View commit details -
Merge pull request #13 from FundingCircle/replace_rails_with_active_r…
…ecord Replace Rails dependency with ActiveRecord
Configuration menu - View commit details
-
Copy full SHA for 96d2e2c - Browse repository at this point
Copy the full SHA 96d2e2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9477caa - Browse repository at this point
Copy the full SHA 9477caaView commit details -
Merge pull request #14 from FundingCircle/bump_to_v0.6.0
Bump to v0.6.0
Configuration menu - View commit details
-
Copy full SHA for 439808f - Browse repository at this point
Copy the full SHA 439808fView commit details
Commits on Oct 16, 2018
-
Don't rely on Rails for the default encoding
If we've included vault-rails in an application that doesn't use rails but only uses activerecord then we won't have access to `Rails.application.config` to ask for `encoding`. We wrap access to this in some guard clauses. Ideally we'd use the encoding on the database connection for the model, but the `Vault::Rails.encrypt` and `Vault::Rails.decrypt` methods don't know about models. We could change these methods to take an optional encoding parameter that the `Vault::Rails::EncryptedModel` will pass in from the database connection. However, we'd still need to work out a default for the cases where we use these methods outside the context of a model, so being more robust in the absence of a full rails application is good enough for now.
Configuration menu - View commit details
-
Copy full SHA for 4e81a3e - Browse repository at this point
Copy the full SHA 4e81a3eView commit details -
Use
ActiveRecord::Base.logger
instead ofRails.logger
We only rely on activerecord now, not the full rails gem so it makes sense to use the `ActiveRecord::Base.logger` instead of attempting to use the `Rails.logger` if rails is available. We don't need to guard against `ActiveRecord::Base` being defined though, as if it's not we'll have much bigger problems than whether or not we can use the logger.
Configuration menu - View commit details
-
Copy full SHA for ddd1142 - Browse repository at this point
Copy the full SHA ddd1142View commit details -
Fix typo in convergent_encryption_context getter error
We also make the method and docs for it look more like the one we get from `Vault::Rails.application` when it's not set.
Configuration menu - View commit details
-
Copy full SHA for a66c7c8 - Browse repository at this point
Copy the full SHA a66c7c8View commit details -
Allow explicitly setting a default encoding value
If we can't rely on there being a full Rails app to get a default encoding from, and we can't rely on the database connection for the models either then it makes sense to allow setting an encoding explicitly for Vault::Rails. In most cases this will be excessive as we will be using it in a rails app and can rely on that value, but for the few cases where we can't this makes sense. If the value is explicitly set we use that, if not we fall back to the `Rails.application.config.encoding` value and if that is not set (or not present because we're not in a rails app), we fall back to a hardcoded default of UTF-8. We've also made setting this value more robust by making sure that whatever value is set is really a valid encoding.
Configuration menu - View commit details
-
Copy full SHA for df5f9fc - Browse repository at this point
Copy the full SHA df5f9fcView commit details -
Merge pull request #15 from FundingCircle/decrease-reliance-on-rails-…
…even-more Decrease reliance on rails even more
Configuration menu - View commit details
-
Copy full SHA for c09936e - Browse repository at this point
Copy the full SHA c09936eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4135e9 - Browse repository at this point
Copy the full SHA e4135e9View commit details -
Merge pull request #17 from FundingCircle/allow_nil_in_json_serializer
Allow nil values in JSON serializer.
Configuration menu - View commit details
-
Copy full SHA for 7d979c5 - Browse repository at this point
Copy the full SHA 7d979c5View commit details -
We need to create a git tag to do the actual release.
Configuration menu - View commit details
-
Copy full SHA for dcf526b - Browse repository at this point
Copy the full SHA dcf526bView commit details -
Merge pull request #19 from FundingCircle/bump-to-v0.6.1
Bump to version 0.6.1
Configuration menu - View commit details
-
Copy full SHA for 7cd818d - Browse repository at this point
Copy the full SHA 7cd818dView commit details
Commits on Oct 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 93889d5 - Browse repository at this point
Copy the full SHA 93889d5View commit details -
Merge pull request #20 from FundingCircle/bump_active_record
Bump lowest supported version of ActiveRecord and Rails.
Configuration menu - View commit details
-
Copy full SHA for 818f1df - Browse repository at this point
Copy the full SHA 818f1dfView commit details
Commits on Oct 24, 2018
-
* Update CircelCI config * Use a docker image with RVM for CircleCI * Use WWTD for running tests with multiple Ruby/Rails versions
Configuration menu - View commit details
-
Copy full SHA for 7dd889e - Browse repository at this point
Copy the full SHA 7dd889eView commit details -
Merge pull request #25 from FundingCircle/improve_circleci_integration
Improve CircleCI Integration
Configuration menu - View commit details
-
Copy full SHA for 3facda6 - Browse repository at this point
Copy the full SHA 3facda6View commit details -
Use Attribute API instead of instance variables for encrypted attributes.
Configuration menu - View commit details
-
Copy full SHA for bb05868 - Browse repository at this point
Copy the full SHA bb05868View commit details -
Merge pull request #16 from FundingCircle/attribute_api
Attribute API
Configuration menu - View commit details
-
Copy full SHA for f3c0a91 - Browse repository at this point
Copy the full SHA f3c0a91View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcf0725 - Browse repository at this point
Copy the full SHA dcf0725View commit details -
Merge pull request #24 from FundingCircle/rails_5.2
Increase highest supported version of ActiveRecord to 5.2+ and < 6.0
Configuration menu - View commit details
-
Copy full SHA for a2ff086 - Browse repository at this point
Copy the full SHA a2ff086View commit details -
Configuration menu - View commit details
-
Copy full SHA for b935c98 - Browse repository at this point
Copy the full SHA b935c98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cf34ad - Browse repository at this point
Copy the full SHA 9cf34adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42aab74 - Browse repository at this point
Copy the full SHA 42aab74View commit details -
Configuration menu - View commit details
-
Copy full SHA for aab627d - Browse repository at this point
Copy the full SHA aab627dView commit details -
Merge pull request #23 from FundingCircle/attribute_proxy
Add attribute proxy for transition between plaintext and ciphertext fields
Configuration menu - View commit details
-
Copy full SHA for 94dbff1 - Browse repository at this point
Copy the full SHA 94dbff1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0f01c - Browse repository at this point
Copy the full SHA 9d0f01cView commit details -
Merge pull request #26 from FundingCircle/bump_to_v0.7.0
Bump to v0.7.0
Configuration menu - View commit details
-
Copy full SHA for 9ba2268 - Browse repository at this point
Copy the full SHA 9ba2268View commit details -
Configuration menu - View commit details
-
Copy full SHA for a56769c - Browse repository at this point
Copy the full SHA a56769cView commit details -
Merge pull request #27 from FundingCircle/fix_circleci_config
Fix indentation in CircleCI config
Configuration menu - View commit details
-
Copy full SHA for ebb88ed - Browse repository at this point
Copy the full SHA ebb88edView commit details
Commits on Oct 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3df72c1 - Browse repository at this point
Copy the full SHA 3df72c1View commit details -
Merge pull request #31 from FundingCircle/add-docs-for-setting-up-tes…
…t-db Mention how to setup the test db
Configuration menu - View commit details
-
Copy full SHA for 43ac087 - Browse repository at this point
Copy the full SHA 43ac087View commit details
Commits on Nov 12, 2018
-
We include the 0.6.2 and 0.6.3 changes from the 0.6.x branch and update the 0.7.x description to mention the breaking changes from 0.6 to 0.7.
Configuration menu - View commit details
-
Copy full SHA for 7cf0581 - Browse repository at this point
Copy the full SHA 7cf0581View commit details -
Merge pull request #38 from FundingCircle/update-changelog-for-master
Update changelog for 0.7.x
Configuration menu - View commit details
-
Copy full SHA for c10d63f - Browse repository at this point
Copy the full SHA c10d63fView commit details -
Test against rails 5, 5.1, and 5.2 not just 4.2
We add the new rails gemfiles using the `appraisals` gem. This means that we can run `bundle exec appraisal rake` locally to run the specs against rails 4.2, 5, 5.1, and 5.2. We've also added these gemfiles to the `.travis.yml` so these rails versions are added to the ruby version test matrix that we run on CI. Note that although we use CircleCI to run our CI tests, we use the `wwtd` gem to read the `.travis.yml` config and do what it would do. This is confusing, but it works.
Configuration menu - View commit details
-
Copy full SHA for 98a6a95 - Browse repository at this point
Copy the full SHA 98a6a95View commit details -
Fix bug with
vault_persist_before_save!
and rails 5.2In rails 5.2 the behaviour of dirty tracking methods changed when they are run during callbacks. Methods like `<attribute>_changed?` and `changes` do the same thing in callbacks run before save, but will behave differently in callbacks run after save. We'd already written `__vault_encrypt_attribute` to understand this and use the `saved_change_to_attribute?` method instead of `<attribute>_changed?` method for rails 5.2. Unfortunately, this is only the correct approach when we're running `__vault_encrypt_attribute` in an `after_save` callback, which we're not if we have run `vault_persist_before_save!`. This means `__vault_encrypte_attribute` is run in a `before_save` callback where the `saved_change_to_attribute?` methods don't do what we want (because we haven't saved any changes yet). In this case we do want to use the old API that the raisl < 5.2 branch uses.
Configuration menu - View commit details
-
Copy full SHA for bdb80c8 - Browse repository at this point
Copy the full SHA bdb80c8View commit details -
Clear up Person vs. EagerPerson when testing vault_persist_before_save!
We use `Person` in the "when not used" context because that model class has not had `vault_persist_before_save!` called on it. `EagerPerson` has and that's why we use it in the "when used" context. It'd be clearer if we could explicitly call it in the spec, but there's no clean up option to unset it so we need separate models.
Configuration menu - View commit details
-
Copy full SHA for f99aebd - Browse repository at this point
Copy the full SHA f99aebdView commit details -
Merge pull request #36 from FundingCircle/fix-persist-before-save-in-…
…rails-5.2 Fix persist before save in rails 5.2
Configuration menu - View commit details
-
Copy full SHA for 258e000 - Browse repository at this point
Copy the full SHA 258e000View commit details -
Configuration menu - View commit details
-
Copy full SHA for 606dcb3 - Browse repository at this point
Copy the full SHA 606dcb3View commit details -
Merge pull request #32 from FundingCircle/improve_vault_attribute_loa…
…ding Improve loading of encrypted attributes.
Configuration menu - View commit details
-
Copy full SHA for af6d13e - Browse repository at this point
Copy the full SHA af6d13eView commit details
Commits on Nov 13, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 87de1df - Browse repository at this point
Copy the full SHA 87de1dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bdb766 - Browse repository at this point
Copy the full SHA 6bdb766View commit details -
Merge pull request #22 from FundingCircle/batch-encrypt-and-decrypt
Add methods for batch decryption and encryption
Configuration menu - View commit details
-
Copy full SHA for 3412d3c - Browse repository at this point
Copy the full SHA 3412d3cView commit details
Commits on Nov 21, 2018
-
Introduce deprecation warnings for 0.6->0.7 differences
This means giving people a warning that `type` is meaningless on `vault_attribute_proxy` now and they should move their type information to the `vault_attribute` definition. This also means reintroducing the `Vault::AttributeProxy` module and having it do nothing but emit a deprecation warning telling you to stop including it.
Configuration menu - View commit details
-
Copy full SHA for 30092d1 - Browse repository at this point
Copy the full SHA 30092d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for eabde1c - Browse repository at this point
Copy the full SHA eabde1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for beb5a4e - Browse repository at this point
Copy the full SHA beb5a4eView commit details -
Bump to 0.7.1 in preparation for release
This also involves updating the gemfiles used by appraisal to run the tests against multiple rails versions to get the new 0.7.1 version.
Configuration menu - View commit details
-
Copy full SHA for 6e19b99 - Browse repository at this point
Copy the full SHA 6e19b99View commit details -
Merge pull request #42 from FundingCircle/documentation-and-upgrade-p…
…ath-fixes Prepare for 0.7.1 release
Configuration menu - View commit details
-
Copy full SHA for 9036e8b - Browse repository at this point
Copy the full SHA 9036e8bView commit details
Commits on Dec 3, 2018
-
Actually drop support for rails 4.x
When we initially created version 0.7 of the gem to use the activerecord attributes API, our goal was to create a unified version that worked with rails 4.x and 5.x. We ultimately failed in that because the attribute API is private in rails 4.x and does not have the exact same behaviour as it does in rails 5.x. We decided that version 0.6 of the gem would support rails 4.x and version 0.7 would support rails 5.x. We didn't actually make this choice explicit though, and so now we do. This allows us to use rails 5.x features properly.
Configuration menu - View commit details
-
Copy full SHA for 1823cc0 - Browse repository at this point
Copy the full SHA 1823cc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa4a1c2 - Browse repository at this point
Copy the full SHA aa4a1c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64bb172 - Browse repository at this point
Copy the full SHA 64bb172View commit details -
Introduce serializers for
time
anddatetime
These might seem redundant, but we'll shortly be introducing the ability to detect the serializer from the type, and these are both types that rails provides by default for attributes so it makes sense to support them.
Configuration menu - View commit details
-
Copy full SHA for a373093 - Browse repository at this point
Copy the full SHA a373093View commit details -
Use
ActiveRecord::Type.lookup
to find type classesOur original strategy of looking for `ActiveRecord::Type::<the type>` works for all the default rails types, but it doesn't allow us to make use of any custom types that our database adapter might introduce. In rails 5+ `ActiveRecord::Type.lookup` was introduced to let us find a type implementation that has previously been registered. This means we can use the same set of types as our database columns, but also any custom types that we might register ourselves (like a Money class or whatever). This change is why we finally dropped support for rail 4.x as it does not have this functionality so it's impossible to know what other custom types are available at runtime.
Configuration menu - View commit details
-
Copy full SHA for 49e3340 - Browse repository at this point
Copy the full SHA 49e3340View commit details -
Detect serializer based on type for vault_attribute
For most cases, if we have specified a `type` option on `vault_attribute` we will also need a serializer to deal with sending the value to vault as a string, and converting it back again. For most cases, we can also detect the serializer based on the type and this means the author of the `vault_attribute` definitions doesn't need to worry about it.
Configuration menu - View commit details
-
Copy full SHA for 7d49ad3 - Browse repository at this point
Copy the full SHA 7d49ad3View commit details -
Add a serializer for IPAddr objects
In postgresql there are inet and cidr types for columns that are handled by the `ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Cidr` and `ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Inet` type classes. This means we get ruby `IPAddr` objects as the value for our attributes when we read them out of the database with `ActiveRecord`. We want to support these column types out of the box so we've introduced a serializer for `IPAddr` (based heavily on the implementation of the type class) and set this serializer as the default for the `inet` and `cidr` types. We also want to support `IPAddr` serialization for other column types that might use `IPAddr` so we've also added it as the serializer for `ipaddr`, so that other database adapters are not beholden to the names postgresql uses.
Configuration menu - View commit details
-
Copy full SHA for 5daba09 - Browse repository at this point
Copy the full SHA 5daba09View commit details -
Merge pull request #44 from FundingCircle/new-inet-type-and-automatic…
…-type-to-serializer-mappings New inet type and automatic type to serializer mappings
Configuration menu - View commit details
-
Copy full SHA for 00fc07e - Browse repository at this point
Copy the full SHA 00fc07eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbd9a57 - Browse repository at this point
Copy the full SHA cbd9a57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5197e63 - Browse repository at this point
Copy the full SHA 5197e63View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9c1aed - Browse repository at this point
Copy the full SHA b9c1aedView commit details
Commits on Dec 10, 2018
-
Handle blank values in batch encryption and decryption
This is a cherry-pick and squash of the following commits from the 0.6 branch which add handling of blank values in the array of plaintexts and handling of the entire array being full of blank values: * f631432 - Handle blank values in batch encryption and decryption * da08d60 - Batch encryption - handle arrays with only blank values We squashed it because the second is really a bug fix of the first so it makes sense to have a single fixed commit when we have that option.
Configuration menu - View commit details
-
Copy full SHA for 662b0c5 - Browse repository at this point
Copy the full SHA 662b0c5View commit details -
Merge pull request #50 from FundingCircle/fix-batch-encryption-for-0.7
Handle blank values in batch encryption and decryption
Configuration menu - View commit details
-
Copy full SHA for bfbe76a - Browse repository at this point
Copy the full SHA bfbe76aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef90d72 - Browse repository at this point
Copy the full SHA ef90d72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 319a0fb - Browse repository at this point
Copy the full SHA 319a0fbView commit details -
Merge pull request #51 from FundingCircle/bump-to-v0.7.3
Bump to v0.7.3
Configuration menu - View commit details
-
Copy full SHA for 3c1c0ce - Browse repository at this point
Copy the full SHA 3c1c0ceView commit details
Commits on Dec 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fb25ed1 - Browse repository at this point
Copy the full SHA fb25ed1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6369a38 - Browse repository at this point
Copy the full SHA 6369a38View commit details -
Add EncryptedModel methods for batch operations
.vault_persist_all and .vault_load_all are methods, that can be used for batch operations of several records. .vault_load_all is useful only when in combination with lazy decryption. Note that although this commit is forwardported from the 0.6 version we've updated the implementation to work with the rails 5 attribute API we use in 0.7.
Configuration menu - View commit details
-
Copy full SHA for 24722f1 - Browse repository at this point
Copy the full SHA 24722f1View commit details -
Extract attribute batch operations in PerformInBatches
For both encryption and decryption we need the same initialization phase of reading the configuration options. The idea is to avoid code repetition and cluttering even more code in EncryptedModel. Note that although this commit is forwardported from the 0.6 version we've updated the implementation to work with the rails 5 attribute API we use in 0.7.
Configuration menu - View commit details
-
Copy full SHA for 222f0e7 - Browse repository at this point
Copy the full SHA 222f0e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b67bc0d - Browse repository at this point
Copy the full SHA b67bc0dView commit details -
Merge pull request #53 from FundingCircle/add-model-level-batch-api-t…
…o-0.7 Add model level batch api to 0.7
Configuration menu - View commit details
-
Copy full SHA for aef596d - Browse repository at this point
Copy the full SHA aef596dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd5d47f - Browse repository at this point
Copy the full SHA bd5d47fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d80258 - Browse repository at this point
Copy the full SHA 0d80258View commit details
Commits on Dec 17, 2018
-
Add option for uniqueness validation of vault attributes
Only convergent attributes can be checked for uniqueness
Configuration menu - View commit details
-
Copy full SHA for f284c24 - Browse repository at this point
Copy the full SHA f284c24View commit details -
Encrypt plaintext in a separate method
.encrypt_value
Encrypting values is necessary not only in attribute setters, but also in the uniqueness validator. In order to avoid duplication, the encryption is extracted in a separate method
Configuration menu - View commit details
-
Copy full SHA for eefca32 - Browse repository at this point
Copy the full SHA eefca32View commit details -
Add ability to search by vault attributes
You can search only by convergently encrypted attributes
Configuration menu - View commit details
-
Copy full SHA for 25515a6 - Browse repository at this point
Copy the full SHA 25515a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 627a73a - Browse repository at this point
Copy the full SHA 627a73aView commit details -
Merge pull request #57 from FundingCircle/search-and-validations
Search and Validations
Configuration menu - View commit details
-
Copy full SHA for a1a818e - Browse repository at this point
Copy the full SHA a1a818eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e30a0fd - Browse repository at this point
Copy the full SHA e30a0fdView commit details -
Merge pull request #58 from FundingCircle/bump-to-v0.7.5
Bump version to v0.7.5
Configuration menu - View commit details
-
Copy full SHA for 38988f4 - Browse repository at this point
Copy the full SHA 38988f4View commit details
Commits on Feb 27, 2019
-
Add validate option to vault_persist_all
In case of invalid records we might still want to persist them
Configuration menu - View commit details
-
Copy full SHA for 995af77 - Browse repository at this point
Copy the full SHA 995af77View commit details -
Configuration menu - View commit details
-
Copy full SHA for a519f24 - Browse repository at this point
Copy the full SHA a519f24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5285fea - Browse repository at this point
Copy the full SHA 5285feaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16c7210 - Browse repository at this point
Copy the full SHA 16c7210View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d11249 - Browse repository at this point
Copy the full SHA 2d11249View commit details -
Merge pull request #63 from FundingCircle/add-validation-option-to-va…
…ult-persist-all Add validation option to vault persist all
Configuration menu - View commit details
-
Copy full SHA for 43abbbf - Browse repository at this point
Copy the full SHA 43abbbfView commit details
Commits on Mar 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f9ca096 - Browse repository at this point
Copy the full SHA f9ca096View commit details -
Merge pull request #64 from FundingCircle/uniqueness_validator_cleans…
…e_error_messages Cleanse error messages when uniqueness validation is used
Configuration menu - View commit details
-
Copy full SHA for 0a0406a - Browse repository at this point
Copy the full SHA 0a0406aView commit details -
Ahmet Abdi committed
Mar 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 24cc468 - Browse repository at this point
Copy the full SHA 24cc468View commit details -
Merge pull request #65 from FundingCircle/0_7_7
Bump version to 0.7.7
Configuration menu - View commit details
-
Copy full SHA for 3837d77 - Browse repository at this point
Copy the full SHA 3837d77View commit details
Commits on Mar 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d867df2 - Browse repository at this point
Copy the full SHA d867df2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26c356c - Browse repository at this point
Copy the full SHA 26c356cView commit details -
Merge pull request #68 from FundingCircle/improve_find_by_and_where
Updates find_by and where searching for encrypted fields
Configuration menu - View commit details
-
Copy full SHA for c701ff1 - Browse repository at this point
Copy the full SHA c701ff1View commit details
Commits on Mar 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 29dde57 - Browse repository at this point
Copy the full SHA 29dde57View commit details -
Ahmet Abdi committed
Mar 14, 2019 Configuration menu - View commit details
-
Copy full SHA for f056995 - Browse repository at this point
Copy the full SHA f056995View commit details -
Merge pull request #70 from FundingCircle/adds_encrypted_where_not
Adds encrypted_where_not
Configuration menu - View commit details
-
Copy full SHA for 4cdac9b - Browse repository at this point
Copy the full SHA 4cdac9bView commit details
Commits on Apr 4, 2019
-
Fix deprecation warning for Rails 5.1
Change was introduced here bdb80c8 to fix an incompatible change introduced by version rails 5.2. This change should apply to rails version 5.1 so deprecation warnings are not produced Also specified the rails version for the first migration as it is required in rails post 5.0. Specified 5.0 to match other migration files and reflect the gems supported versions of rails
Configuration menu - View commit details
-
Copy full SHA for 0993db1 - Browse repository at this point
Copy the full SHA 0993db1View commit details
Commits on Apr 8, 2019
-
Merge pull request #72 from FundingCircle/fix-51-deprecation-warning
Fix deprecation warning for Rails 5.1
John Calvin authoredApr 8, 2019 Configuration menu - View commit details
-
Copy full SHA for b1c1d2b - Browse repository at this point
Copy the full SHA b1c1d2bView commit details
Commits on Apr 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4fa8176 - Browse repository at this point
Copy the full SHA 4fa8176View commit details -
Move version requiring before all
Ahmet Abdi committedApr 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 0a0bc92 - Browse repository at this point
Copy the full SHA 0a0bc92View commit details -
Merge pull request #74 from FundingCircle/merging_master_and_0_6_branch
Merge 0.6 and master branches to add support for Rails >= 4.2
Configuration menu - View commit details
-
Copy full SHA for b879e6c - Browse repository at this point
Copy the full SHA b879e6cView commit details -
Ahmet Abdi committed
Apr 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 2a4107b - Browse repository at this point
Copy the full SHA 2a4107bView commit details -
Merge pull request #75 from FundingCircle/2_0_0
Bump version to 2.0.0
Configuration menu - View commit details
-
Copy full SHA for 0a3898b - Browse repository at this point
Copy the full SHA 0a3898bView commit details
Commits on Apr 29, 2019
-
Override .attributes method on legacy EncryptedModel and adds .unencr…
…ypted_attributes method
Configuration menu - View commit details
-
Copy full SHA for 9fe3af9 - Browse repository at this point
Copy the full SHA 9fe3af9View commit details
Commits on Apr 30, 2019
-
Update unencrypted_attributes method to use vault_attributes for retr…
…ieving encryted_column
Ahmet Abdi committedApr 30, 2019 Configuration menu - View commit details
-
Copy full SHA for 2263c4b - Browse repository at this point
Copy the full SHA 2263c4bView commit details
Commits on May 2, 2019
-
Merge pull request #76 from FundingCircle/gdpreng-894_override_attrib…
…utes_legacy Override .attributes method on legacy EncryptedModel and adds .unencr…
Configuration menu - View commit details
-
Copy full SHA for 56989b2 - Browse repository at this point
Copy the full SHA 56989b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2923a69 - Browse repository at this point
Copy the full SHA 2923a69View commit details -
Merge pull request #77 from FundingCircle/version_2_0_1
Bump version to 2.0.1
Configuration menu - View commit details
-
Copy full SHA for 0ffd1ae - Browse repository at this point
Copy the full SHA 0ffd1aeView commit details
Commits on May 16, 2019
-
Fixes bug with memory decryption not handing blank values
Ahmet Abdi committedMay 16, 2019 Configuration menu - View commit details
-
Copy full SHA for 2d40b4e - Browse repository at this point
Copy the full SHA 2d40b4eView commit details -
Merge pull request #78 from FundingCircle/bug_with_vault_load_all_and…
…_in_memory Fixes bug with memory decryption not handing blank values
Configuration menu - View commit details
-
Copy full SHA for 659ec59 - Browse repository at this point
Copy the full SHA 659ec59View commit details -
Ahmet Abdi committed
May 16, 2019 Configuration menu - View commit details
-
Copy full SHA for 0c826c7 - Browse repository at this point
Copy the full SHA 0c826c7View commit details
Commits on May 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7e145d9 - Browse repository at this point
Copy the full SHA 7e145d9View commit details
Commits on Aug 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 94da2ba - Browse repository at this point
Copy the full SHA 94da2baView commit details -
Merge pull request #80 from FundingCircle/fix_issue_in_json_serializa…
…tion Update JSONSerializer when encoding to return value if already a JSON…
Ahmet Abdi authoredAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for 2af00f6 - Browse repository at this point
Copy the full SHA 2af00f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 191b1ee - Browse repository at this point
Copy the full SHA 191b1eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5d8bbc - Browse repository at this point
Copy the full SHA d5d8bbcView commit details
Commits on Dec 2, 2019
-
Remove travis-ci dependency by moving completely to CircleCI
The "wwtd" rubygem along with Travis CI configuration file basically run the suite test against different versions of Ruby and Rails. This causes problems when the ruby/rails combination are ruby versions lower than 2.5 and the rails version is 6 since this version of rails only supports ruby version 2.5.0 or higher.
Configuration menu - View commit details
-
Copy full SHA for 8fcc037 - Browse repository at this point
Copy the full SHA 8fcc037View commit details -
SQLite3 gem on ActiveRecord 6 needs to be higher than 1.3, this commit makes sure each Gemfile has its proper version
Configuration menu - View commit details
-
Copy full SHA for c075fea - Browse repository at this point
Copy the full SHA c075feaView commit details -
Merge pull request #82 from FundingCircle/add-rails6-support
Add Rails 6 support
Kleber Correia authoredDec 2, 2019 Configuration menu - View commit details
-
Copy full SHA for 7e700d9 - Browse repository at this point
Copy the full SHA 7e700d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e39ed30 - Browse repository at this point
Copy the full SHA e39ed30View commit details -
Merge pull request #84 from FundingCircle/bump-version
Bump version
Kleber Correia authoredDec 2, 2019 Configuration menu - View commit details
-
Copy full SHA for d6a60ad - Browse repository at this point
Copy the full SHA d6a60adView commit details
Commits on Apr 2, 2020
-
- ruby 2.4 - ruby 2.5 - ruby 2.6 - ruby 2.7
Configuration menu - View commit details
-
Copy full SHA for ec5859e - Browse repository at this point
Copy the full SHA ec5859eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04648b2 - Browse repository at this point
Copy the full SHA 04648b2View commit details
Commits on Apr 3, 2020
-
Merge pull request #86 from FundingCircle/update-ci
Update ruby versions in ci
Configuration menu - View commit details
-
Copy full SHA for 13c3653 - Browse repository at this point
Copy the full SHA 13c3653View commit details
Commits on Oct 19, 2020
-
Do not pollute record changes when loading attributes for the first time
This is done as in rails >= 5.2 the lock! & with_lock methods now require that the record doesn't have any changes otherwise they'll raise an error. https://github.com/rails/rails/blob/v5.2.4.4/activerecord/lib/active_record/locking/pessimistic.rb#L65 ``` def lock!(lock = true) if persisted? if has_changes_to_save? raise(<<-MSG.squish) Locking a record with unpersisted changes is not supported. Use `save` to persist the changes, or `reload` to discard them explicitly. MSG end reload(lock: lock) end self end ``` Apparently clear_attribute_changes receives an array of attributes which it should clear. https://apidock.com/rails/v5.2.3/ActiveModel/Dirty/clear_attribute_changes
Configuration menu - View commit details
-
Copy full SHA for 13c29cc - Browse repository at this point
Copy the full SHA 13c29ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1234929 - Browse repository at this point
Copy the full SHA 1234929View commit details
Commits on Oct 20, 2020
-
Merge pull request #88 from FundingCircle/do-not-pollute-model-changes
Do not pollute model changes on initialisation
Configuration menu - View commit details
-
Copy full SHA for 887e708 - Browse repository at this point
Copy the full SHA 887e708View commit details
Commits on Jan 11, 2022
-
Test bug in rails 5 db:create / assets:precompile
When running db:create or assets:precompile the gem does a db connection for no reason in rails 5.x. In rails 4 it is not doing it. The bug happens here: https://github.com/rails/rails/blob/v5.2.6/activerecord/lib/active_record/type.rb#L41 ``` def lookup(*args, adapter: current_adapter_name, **kwargs) # :nodoc: ``` `current_adapter_name` for some reason does a db connection.
Configuration menu - View commit details
-
Copy full SHA for d0bc93e - Browse repository at this point
Copy the full SHA d0bc93eView commit details -
The lookup call tries to establish connection to the database when the application code is loading. This bugs rake tasks like db:create / assets:precompile https://github.com/rails/rails/blob/v5.2.6/activerecord/lib/active_record/type.rb#L41 ``` def lookup(*args, adapter: current_adapter_name, **kwargs) # :nodoc: ``` The `current_adapter_name` for some reason does a db connection. The code is change to getting the current adapter with `ActiveRecord::Base.connection_config[:adapter]`, which is not making a db connection.
Configuration menu - View commit details
-
Copy full SHA for 006f61c - Browse repository at this point
Copy the full SHA 006f61cView commit details -
Merge pull request #87 from FundingCircle/fix-rails-db-create
Fix crashes when there isn't a database
Configuration menu - View commit details
-
Copy full SHA for 93bd3f2 - Browse repository at this point
Copy the full SHA 93bd3f2View commit details
Commits on Jan 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a92bfba - Browse repository at this point
Copy the full SHA a92bfbaView commit details
Commits on Feb 1, 2022
-
Merge pull request #90 from FundingCircle/extract-fca-vault-transit-j…
…son-codec Export VaultTransitJsonCodec from fca
Configuration menu - View commit details
-
Copy full SHA for f537b57 - Browse repository at this point
Copy the full SHA f537b57View commit details
Commits on Sep 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 60327f8 - Browse repository at this point
Copy the full SHA 60327f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6af8643 - Browse repository at this point
Copy the full SHA 6af8643View commit details
Commits on Sep 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b6b7b26 - Browse repository at this point
Copy the full SHA b6b7b26View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3e4434 - Browse repository at this point
Copy the full SHA a3e4434View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c8158a - Browse repository at this point
Copy the full SHA 5c8158aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7127d9 - Browse repository at this point
Copy the full SHA c7127d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 346da6b - Browse repository at this point
Copy the full SHA 346da6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c369dc8 - Browse repository at this point
Copy the full SHA c369dc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff30a99 - Browse repository at this point
Copy the full SHA ff30a99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7142278 - Browse repository at this point
Copy the full SHA 7142278View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3182e20 - Browse repository at this point
Copy the full SHA 3182e20View commit details
Commits on Sep 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fdd809a - Browse repository at this point
Copy the full SHA fdd809aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9bc5d6 - Browse repository at this point
Copy the full SHA f9bc5d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 959e061 - Browse repository at this point
Copy the full SHA 959e061View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8887e40 - Browse repository at this point
Copy the full SHA 8887e40View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8db77a - Browse repository at this point
Copy the full SHA e8db77aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ede94f - Browse repository at this point
Copy the full SHA 7ede94fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03b7d71 - Browse repository at this point
Copy the full SHA 03b7d71View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb2a5e5 - Browse repository at this point
Copy the full SHA cb2a5e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17f66d0 - Browse repository at this point
Copy the full SHA 17f66d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d87070 - Browse repository at this point
Copy the full SHA 7d87070View commit details -
Configuration menu - View commit details
-
Copy full SHA for 124ba04 - Browse repository at this point
Copy the full SHA 124ba04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 789da75 - Browse repository at this point
Copy the full SHA 789da75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bf5e0a - Browse repository at this point
Copy the full SHA 9bf5e0aView commit details
Commits on Sep 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d49eaff - Browse repository at this point
Copy the full SHA d49eaffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1961bf0 - Browse repository at this point
Copy the full SHA 1961bf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f9e90a - Browse repository at this point
Copy the full SHA 2f9e90aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d182fec - Browse repository at this point
Copy the full SHA d182fecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5679ec4 - Browse repository at this point
Copy the full SHA 5679ec4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d5f6af - Browse repository at this point
Copy the full SHA 0d5f6afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d1a293 - Browse repository at this point
Copy the full SHA 8d1a293View commit details -
Configuration menu - View commit details
-
Copy full SHA for 571e346 - Browse repository at this point
Copy the full SHA 571e346View commit details -
Configuration menu - View commit details
-
Copy full SHA for a19cb5a - Browse repository at this point
Copy the full SHA a19cb5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f6c534 - Browse repository at this point
Copy the full SHA 0f6c534View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e89c6f - Browse repository at this point
Copy the full SHA 5e89c6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for db94ebe - Browse repository at this point
Copy the full SHA db94ebeView commit details
Commits on Sep 25, 2023
-
Merge pull request #93 from FundingCircle/cd-150-codeowners
Adding codeowners
Configuration menu - View commit details
-
Copy full SHA for edb946a - Browse repository at this point
Copy the full SHA edb946aView commit details -
Configuration menu - View commit details
-
Copy full SHA for df0d091 - Browse repository at this point
Copy the full SHA df0d091View commit details -
Merge branch 'cd-150-support-rails-7' of github.com:FundingCircle/fc-…
…vault-rails into cd-150-support-rails-7
Configuration menu - View commit details
-
Copy full SHA for 4342d1c - Browse repository at this point
Copy the full SHA 4342d1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4e48e4 - Browse repository at this point
Copy the full SHA b4e48e4View commit details -
Merge pull request #91 from FundingCircle/cd-150-support-rails-7
Added rails 7
Configuration menu - View commit details
-
Copy full SHA for be401b3 - Browse repository at this point
Copy the full SHA be401b3View commit details
Commits on Nov 17, 2023
-
Fix deprecation warning when using connection_config
``` ActiveRecord::Base.try(:connection_db_config).try(:adapter) => "postgresql" ActiveRecord::Base.try(:connection_config)[:adapter] W, [2023-11-17T16:12:59.253878+02:00 #22587] DEPRECATION WARNING: connection_config is deprecated and will be removed from Rails 7.0 (Use connection_db_config instead) (called from <main> at (pry):6) => "postgresql" ```
Configuration menu - View commit details
-
Copy full SHA for 07884a0 - Browse repository at this point
Copy the full SHA 07884a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 679ca5e - Browse repository at this point
Copy the full SHA 679ca5eView commit details -
Add rails 7 support Fixes DEPRECATION WARNING: connection_config is deprecated and will be removed from Rails 7.0
Configuration menu - View commit details
-
Copy full SHA for 83ca019 - Browse repository at this point
Copy the full SHA 83ca019View commit details
Commits on Nov 20, 2023
-
Merge pull request #94 from FundingCircle/fix-deprecation-warning
Fix deprecation warning when using connection_config
Configuration menu - View commit details
-
Copy full SHA for 4f54148 - Browse repository at this point
Copy the full SHA 4f54148View commit details
Commits on Nov 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6497f8c - Browse repository at this point
Copy the full SHA 6497f8cView commit details -
Merge pull request #97 from FundingCircle/fix-promote-build
Fix the promote build
Configuration menu - View commit details
-
Copy full SHA for 24fc43c - Browse repository at this point
Copy the full SHA 24fc43cView commit details
Commits on Dec 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e21f79c - Browse repository at this point
Copy the full SHA e21f79cView commit details