Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessor to sys.auths response #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saraislet
Copy link

Hi! Returning the accessor with sys.auths would simplify some work we're doing for managing auth methods.

I added tests, with I think the reasonable assumption that the token auth mount is always created and that we don't need to test the value of the accessor since it is not feasibly predictable (I gather that Vault's golang tests also make this assumption).

The existing tests are somewhat bare. Is this sufficient, and reasonably in line with existing tests? Thanks : )

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Sarai Rosenberg seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@saraislet
Copy link
Author

😑 I left the company since I signed the agreement, so the email address is no longer mine to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants