Add patch_metadata method to kv api #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dhuckins
reviewed
Jun 9, 2023
lib/vault/api/kv.rb
Outdated
| # be a {Hash}. | ||
| # | ||
| # @example | ||
| # Vault.kv("secret").patch_metadata("password", custom_metadata: { data: update }, max_versions => 3) |
There was a problem hiding this comment.
Suggested change
| # Vault.kv("secret").patch_metadata("password", custom_metadata: { data: update }, max_versions => 3) | |
| # Vault.kv("secret").patch_metadata("password", custom_metadata: { my_custom_key: "my_value" }, max_versions: 3) |
two suggestions:
- removing
dataas the key (datacan get confusing w/ kv-v2 engine) - replaced
=>with:(didn't work with the=>as written)
There was a problem hiding this comment.
@dhuckins Adjusted. The max_versions issue is in a bunch of the other examples in that file, so will probably want to fix those if they have the same issue.
There was a problem hiding this comment.
thanks! do you mind rebasing/pulling upstream branch so the refactored CI can run? (on your branch: git pull master should do the trick)
sorry for the delay
There was a problem hiding this comment.
@dhuckins no worries. should be caught up now
dhuckins
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
patch_metadatamethod to the kv api, as described in https://developer.hashicorp.com/vault/api-docs/secret/kv/kv-v2#patch-metadata. The driver for this was to be able to updatecustom_metadataviapatchrather than re-writing the entire existingcustom_metadatahash.