Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX URI path handling to remove double slashes #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX URI path handling to remove double slashes #344

wants to merge 1 commit into from

Commits on Sep 13, 2024

  1. FIX URI path handling to remove double slashes 

    Fix request URI to remove double slashes.
Vault server returns 301 redirect for double slash URIs, requiring resending.
Since Vault server v1.17.3, the redirect URL has changed.

For example, take key: `/cubbyhole/my-secret`:

- Before vault v1.17.2, vault-ruby sends `/v1//cubbyhole/my%2Dsecret`,
  and the Vault server returns `/v1/cubbyhole/my-secret`.
- After vault v1.17.3, vault-ruby sends `/v1//cubbyhole/my%2Dsecret`,
  and the Vault server returns `/v1/cubbyhole/my%252Dsecret`.

Thus, the behavior is not the same. Removing the double slashes prevents the
redirect mechanism from being triggered.
    @TaopaiC
    TaopaiC committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    327f828 View commit details
    Browse the repository at this point in the history