Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update fathom-client #247

Closed
wants to merge 2 commits into from
Closed

chore: update fathom-client #247

wants to merge 2 commits into from

Conversation

pbortnick
Copy link
Contributor

@pbortnick pbortnick commented Nov 2, 2023

🎟️ Asana Task


Description

Update fathom-client dependency to use new features. Current implementations should still work.

Note: As of Oct 25, 2023, we no longer support trackGoal for new goals/events. If you’re using trackGoal currently, it’ll continue to work, but the new way of doing events is below.

See this doc for more information.

PR Checklist πŸš€

  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Write a useful description (above) to give reviewers appropriate context.
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

Copy link

changeset-bot bot commented Nov 2, 2023

πŸ¦‹ Changeset detected

Latest commit: 7d1fe49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/platform-analytics Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pbortnick pbortnick requested review from a team and EnMod and removed request for a team November 2, 2023 15:16
@pbortnick pbortnick changed the title chore: update fathom chore: update fathom-client Nov 3, 2023
@EnMod
Copy link
Contributor

EnMod commented Nov 3, 2023

LGTM, but I'm thinking it might be worth making a canary release and testing in one of our other repos, just in case πŸ€”

@pbortnick pbortnick added the release:canary Publish a canary release label Nov 3, 2023
@pbortnick
Copy link
Contributor Author

LGTM, but I'm thinking it might be worth making a canary release and testing in one of our other repos, just in case πŸ€”

@EnMod 🧠 smart! I will do that and report back

Copy link
Contributor

@EnMod EnMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbortnick Approved pending positive results from trying out the canary!

@dstaley
Copy link
Contributor

dstaley commented Nov 6, 2023

@pbortnick since this is an update to a version that's still within the semver range for the existing package, we don't need to publish this as an update to the platform-analytics package. You can run npm update fathom-client to get the latest v3.6.0 version within the monorepo.

@pbortnick pbortnick closed this Nov 6, 2023
@pbortnick pbortnick deleted the pb.update-fathom branch November 6, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Publish a canary release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants