Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give write permission to the GHA token #270

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

RubenSandwich
Copy link
Contributor

@RubenSandwich RubenSandwich commented Jul 9, 2024

🎟️ Asana Task - None, fix for not enough permissions in previous fix. #269


Description

We actually have what I believe are enough permissions on the default GHA token. And setting specific permissions actually limits any non specified permissions:

If you specify the access for any of these scopes, all of those that are not specified are set to none.

I also double checked the action that needs this permission changesets/action README and it looks like it should work with the default token.

Soooo try 2.

Testing

None, because we have no local tests for this workflow. 😢

PR Checklist 🚀

  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Write a useful description (above) to give reviewers appropriate context.
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

Copy link

changeset-bot bot commented Jul 9, 2024

⚠️ No Changeset found

Latest commit: 5c3d637

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@RubenSandwich RubenSandwich self-assigned this Jul 9, 2024
@RubenSandwich RubenSandwich merged commit 85e9d52 into main Jul 9, 2024
3 checks passed
@RubenSandwich RubenSandwich deleted the rn/fix/more-GHA-token-perms branch July 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants