Skip to content

[Snyk] Upgrade mkdirp from 0.5.6 to 3.0.1 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hashim21223445 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Upgrade mkdirp from 0.5.6 to 3.0.1 #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"iconv-lite": "^0.7.0",
"in-publish": "^2.0.1",
"jackspeak": "2.3.6",
"mkdirp": "^0.5.5",
"mkdirp": "^3.0.1",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading mkdirp to version 3.0.1 introduces a new minimum Node.js version requirement of >=14.14.

However, this project's package.json specifies support for Node.js versions >=0.6 in its engines field:

"engines": {
    "node": ">=0.6"
}

This discrepancy will cause npm install to fail for any developer or CI environment running on a Node.js version older than 14.14, effectively breaking the development and build process for a large range of the currently supported Node versions.

Since mkdirp is a devDependency used in the dist script, this is a critical breaking change for the project's contribution workflow.

Given that this upgrade is not for a security vulnerability, it is recommended to reject this change to maintain broad Node.js compatibility for developers. Alternatively, the project's supported Node.js range would need to be updated, which is a significant policy decision.

"mock-property": "^1.0.3",
"module-deps": "^6.2.3",
"npmignore": "^0.3.1",
Expand Down
Loading