Port Haskell and JavaScript code to dimensional Metrics. #64
+129
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibbe
reviewed
Apr 24, 2017
| event <- getDistribution "runtime" handle | ||
| handle <- forkServer "0.0.0.0" 8000 | ||
| baseCounter <- getCounter "iterations" [] handle | ||
| fizzCounter <- getCounter "iterations" ["dim0:fizz"] handle |
There was a problem hiding this comment.
Regarding the comment I gave on the pull request in ekg-core. I think its here I'd rather see that the dimension names don't have to be repeated (albeit that does imply they need to be positional).
tibbe
reviewed
Apr 24, 2017
| label <- getLabel "args" handle | ||
| event <- getDistribution "runtime" handle | ||
| handle <- forkServer "0.0.0.0" 8000 | ||
| baseCounter <- getCounter "iterations" [] handle |
There was a problem hiding this comment.
I don't think it makes sense for a counter to be accessed with only some dimensions. What does it mean to increment a counter that has been given e.g. a URL and a HTTP status code dimension without providing values for those when incrementing it?
There was a problem hiding this comment.
For example, what would it mean to sum up all the values in a metric if you have "global" counts and indexed counts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experiment goes with haskell-github-trust/ekg-core#17 and haskell-github-trust/ekg-json#6 .
FizzBuzz in EKG:
