Matching Down instance instead of Min

haskell · Jun 6, 2024 · 806a832 · 806a832
1 parent 57cd653
commit 806a832
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 18 deletions.
diff --git a/src/Data/Aeson/Types/FromJSON.hs b/src/Data/Aeson/Types/FromJSON.hs
@@ -2335,33 +2335,21 @@ instance FromJSON a => FromJSON (Monoid.Dual a) where
     parseJSON = parseJSON1
 
 instance FromJSON1 Monoid.Sum where
-    liftParseJSON _ p _ a = coerce (p a)
-
-    liftParseJSONList _ _ p a = coerce (p a)
+    liftParseJSON _ p _ = coerce p
 
     liftOmittedField = coerce
 
 instance (FromJSON a) => FromJSON (Monoid.Sum a) where
     parseJSON = parseJSON1
 
-    parseJSONList = liftParseJSONList omittedField parseJSON parseJSONList
-
-    omittedField = omittedField1
-
 instance FromJSON1 Monoid.Product where
-    liftParseJSON _ p _ a = coerce (p a)
-
-    liftParseJSONList _ _ p a = coerce (p a)
+    liftParseJSON _ p _ = coerce p
 
     liftOmittedField = coerce
 
 instance (FromJSON a) => FromJSON (Monoid.Product a) where
     parseJSON = parseJSON1
 
-    parseJSONList = liftParseJSONList omittedField parseJSON parseJSONList
-
-    omittedField = omittedField1
-
 instance FromJSON Monoid.All where
     parseJSON = coerce . (parseJSON :: Value -> Parser Bool)
 

diff --git a/src/Data/Aeson/Types/ToJSON.hs b/src/Data/Aeson/Types/ToJSON.hs
@@ -2101,25 +2101,28 @@ instance ToJSON a => ToJSON (Monoid.Dual a) where
     omitField = omitField1
 
 instance ToJSON1 Monoid.Sum where
-    liftToJSON _ t _ = t . Monoid.getSum
-    liftToEncoding _ t _ = t . Monoid.getSum
+    liftToJSON _ t _ = coerce t
+    liftToEncoding _ t _ = coerce t
     liftOmitField = coerce
 
+
 instance ToJSON a => ToJSON (Monoid.Sum a) where
     toJSON = toJSON1
     toEncoding = toEncoding1
     omitField = omitField1
 
+
 instance ToJSON1 Monoid.Product where
-    liftToJSON _ t _ = t . Monoid.getProduct
-    liftToEncoding _ t _ = t . Monoid.getProduct
+    liftToJSON _ t _ = coerce t
+    liftToEncoding _ t _ = coerce t
     liftOmitField = coerce
 
 instance ToJSON a => ToJSON (Monoid.Product a) where
     toJSON = toJSON1
     toEncoding = toEncoding1
     omitField = omitField1
 
+
 instance ToJSON Monoid.All where
     toJSON = toJSON . Monoid.getAll
     toEncoding = toEncoding . Monoid.getAll