Skip to content

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Aug 30, 2025

Closes #11197


Manual QA

cd /tmp/
cabal init foo-α
cd foo-α
cabal check

old cabal will not complain about non-ASCII chars in package name, new cabal will.

@ffaf1 ffaf1 force-pushed the non-ascii-package-name branch 2 times, most recently from 214aa41 to c17000b Compare August 30, 2025 10:38
@ffaf1 ffaf1 force-pushed the non-ascii-package-name branch from c17000b to 6215e69 Compare August 30, 2025 10:46
@athas
Copy link
Collaborator

athas commented Aug 30, 2025

Is this a full fix? Hackage rejects not only packages with non-ASCII names, but also packages that contain files with non-ASCII names (in my case, it was an extra-source-files file for the test suite).

@ffaf1 ffaf1 changed the title warn on non-ASCII characters in name: Warn on non-ASCII characters in name: Aug 30, 2025
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Aug 30, 2025

Emh I misread the issue, let me work on it some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-manual-qa PR is destined for manual QA
Projects
Status: Waiting
Development

Successfully merging this pull request may close these issues.

'cabal check' or 'cabal sdist' ought to warn about non-ASCII characters
2 participants