Add reinstall test to LinkerOptions/NonignoredConfigs

[philderbeast]

Adds a test of --force-reinstalls.

I found no reinstall tests for #9268 but I did find a LinkerOptions/NonignoredConfigs test where I could add a reinstall test. Unfortunately this doesn't touch the code path of #9268 with its Use --overwrite-policy=always to overwrite message. The message is instead:

Packages requested to install already exist in environment file at ... Overwriting them may break other packages. Use --force-reinstalls to proceed anyway.

• Patches conform to the coding conventions.

[philderbeast]

It is not possible to share a module between *.test.hs tests is it? I had initially had a reinstall.test.hs test but then wondered how I would go about not duplicating this stuff in the module:

cabal/cabal-testsuite/PackageTests/LinkerOptions/NonignoredConfigs/cabal.test.hs

Lines 34 to 51 in 054108f

	data Linking = Static | Dynamic deriving (Eq, Ord, Show)
	links :: [Linking]
	links = [Static, Dynamic]
	linkConfigFlags :: Linking -> [String]
	linkConfigFlags Static =
	[
	]
	linkConfigFlags Dynamic =
	[
	"--enable-shared",
	"--enable-executable-dynamic",
	"--disable-library-vanilla"
	]
	lrun :: [Linking]
	lrun = [Static, Dynamic, Static, Dynamic]

[Mikolaj]

It is not possible to share a module between *.test.hs tests is it?

No idea, but I guess it's less risky to duplicate anyway, in case somebody then changes the test case for one of the tests and consequently subtly changes other tests that use it.

[Mikolaj]

Thank you.

[Mikolaj]

OOI, why merge+no_rebase? I see it resulted in a complex git history (observe, e.g., with gitk).

[philderbeast]

OOI, why merge+no_rebase? I see it resulted in a complex git history (observe, e.g., with gitk).

The merge+no_rebase label is the one that works for merging pull requests from https://github.com/cabalism/cabal.

See #9264 (comment) and #9264 (comment) for more on this.