-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Base16 hash for script path. (backport #9459) #9483
Conversation
Something is quite borked in these CI failures. Let me try to restart. |
No luck. The error from the boostrap tests is
and the one from Validate tests is hard to fathom, but perhaps it's the same thing? |
5d7fe7a
to
7d3f33e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase conflicts are resolved now
@mergify refresh |
✅ Pull request refreshed |
@mergify rebase |
✅ Branch has been successfully rebased |
7d3f33e
to
d84bd02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a change in a test that sneaked in here from another PR, but it seems benign. Please feel free to set the merge label.
I'm unsure which change you mean. All I can see in the diff belongs to this change to Base16, also the changes in |
You are right, I take it back. The addition of Edit: So, actually, it "sneaked" into the original PR, not into the backport. :) |
Issue #9334 shows that `%` characters on Windows result in invalid paths, also `/` characters on Linux create invalid paths. This changes from using base64 to using base16 with the same length we use for unit-ids. (cherry picked from commit 97f9917) Co-authored-by: Hécate Moonlight <Kleidukos@users.noreply.github.com> Co-autohred-by: Javier Sagredo <jasataco@gmail.com>
d84bd02
to
8a35837
Compare
This is an automatic backport of pull request #9459 done by Mergify.
Cherry-pick of 97f9917 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com