Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SetVolumeCommand action topic no longer working #173

Open
3 of 4 tasks
wynandtredoux opened this issue Oct 2, 2024 · 4 comments
Open
3 of 4 tasks

Bug: SetVolumeCommand action topic no longer working #173

wynandtredoux opened this issue Oct 2, 2024 · 4 comments
Labels
bug Something isn't working fixed in beta fix for this issue/request is already present in one of the beta versions

Comments

@wynandtredoux
Copy link

wynandtredoux commented Oct 2, 2024

Describe the bug
After upgrading to 2.1.0 release, SetVolumeCommand no longer works through the action topic. If I set a value for "Volume", then HASS will set system volume to that value when the button is pressed in HomeAssistant. When Volume field is blank (so that value can be set dynamically), then the command does not run when an MQTT message is published to the action topic.

After reverting back to 2.1.0-beta1, everything works as expected again.

To Reproduce
Steps to reproduce the behavior:

  1. Install or update to 2.1.0 release
  2. Click "Commands"
  3. Add new SetVolumeCommand
  4. Leave "Volume" field blank
  5. Store Command
  6. Store and Activate Commands -> new topic is created on MQTT server for SetVolumeCommand
  7. Publish value to action topic of the new command (in my case: homeassistant/button/NEW-DESK/NEW-DESK_setvolume/action)

I see that the action value is changed on the MQTT server (checked with MQTT Explorer), but HASS.Agent does not change the volume. Same result when adding SetVolumeCommand in satellite service.

Expected behavior
Volume should be changed on PC

Misc info (please complete the following information):

  • Windows' UI language: English
  • HASS.Agent version: 2.1.0
    image

Please check what's applicable (multiple answers possible):

  • Installed via installer
  • Installed manually
  • Problem occurs in HASS.Agent
  • Problem occurs in Satellite Service

Additional context
After reverting back to the version I had installed previously (2.1.0-beta1), SetVolumeCommand works as expected. I did not try other 2.1.0 beta versions

Logs
I can add logs if needed, but even with extended logging I don't see any log lines when system volume is changed with SetVolumeCommand. I only get a warning log line when the command is triggered as a button:

[WRN] [SETVOLUME] [setvolume] Unable to trigger command, it's configured as action-only

When publishing to setvolume/action, even when the command is working, nothing is logged to AppData\Local\HASS.Agent\Client\logs

@wynandtredoux wynandtredoux added the bug Something isn't working label Oct 2, 2024
@drueppler
Copy link

I might have the same issue, using 2.1.0.

I have lines like the following one in the log file, after the mqtt-publish from HA:
2024-10-04 00:54:01.928 +02:00 [ERR] [SETVOLUME] [volume] Unable to trigger command, the provided action value can't be parsed: 31.0

@amadeo-alex
Copy link
Collaborator

Ok, I've replicated this and those are actually:

  • one bug: the actionable volume command doesn't use the provided payload...
  • one kind of bug: "50.0" cannot be parsed to int so it fails

Both can be solved. Should be fixed soon(TM) and will be part of 2.1.1.

@amadeo-alex
Copy link
Collaborator

If you're comfortable with betas, please try https://github.com/hass-agent/HASS.Agent/releases/tag/2.1.1-beta1 with the mentioned fix. Let me know in case of any issues.

@amadeo-alex amadeo-alex added the fixed in beta fix for this issue/request is already present in one of the beta versions label Oct 19, 2024
@fiskhest
Copy link

👋🏼 Can confirm I saw this issue on 2.1.0 and it works with the version specified ☝🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in beta fix for this issue/request is already present in one of the beta versions
Projects
None yet
Development

No branches or pull requests

4 participants