Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SetVolumeCommand ignoring payload #175

Conversation

amadeo-alex
Copy link
Collaborator

This PR fixes issues of SetVolumeCommand reported via #173:

  • ignoring payload and using internal volume set by default to -1 is not configured (causing no action to be taken)
  • accepting only proper ("50") integers and failing to parse float values ("50.0", "50.5")

After the fix, payload is properly recognised and providing float values causes them to be converted to int by rounding up (i.e. "50.1" and above becomes "51")

@amadeo-alex amadeo-alex merged commit 2dd00f2 into hass-agent:development-2.1.1-beta1 Oct 4, 2024
@amadeo-alex amadeo-alex added this to the 2.1.1 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant