Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCUMENTATION: Proccessings Proofing #287

Merged
merged 2 commits into from
Jul 24, 2024
Merged

DOCUMENTATION: Proccessings Proofing #287

merged 2 commits into from
Jul 24, 2024

Conversation

glhays
Copy link
Collaborator

@glhays glhays commented Jul 23, 2024

Closes: #286

@glhays glhays added the DOCUMENTATION Improvements or additions to documentation label Jul 23, 2024
hassanhabib
hassanhabib reviewed Jul 23, 2024
View reviewed changes
2. Services/2.2 Processings/2.2 Processings.md Outdated
@@ -12,7 +12,7 @@ Here's an example of what a Processing service function would look like:
public ValueTask<Student> UpsertStudentAsync(Student student) =>
TryCatch(async () =>
{
ValidateStudent(student);
ValidateStudentOnUpert(student);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OnUpsert

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eyes!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

hassanhabib
hassanhabib reviewed Jul 23, 2024
View reviewed changes
2. Services/2.2 Processings/2.2 Processings.md Outdated
@@ -21,7 +21,7 @@ TryCatch(async () =>
retrievedStudent.Id == student.Id);

return studentExists switch {
false => await this.studentService.RegisterStudentAsync(student),
false => await this.studentService.AddStudentAsync(student),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay as RegisterStudentAsync the idea here is that the language is more business specific than technical at the Processing layer.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@glhays glhays merged commit 7f04d6d into master Jul 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassanhabib hassanhabib hassanhabib left review comments

Assignees
No one assigned
Labels
DOCUMENTATION Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOCUMENTATION: Proccessings Proofing
2 participants
@glhays @hassanhabib