Silence compiler warnings, safer variable re-binding #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment using this library in a phoenix project will raise this warning on (re)compilation:
where
lib/my_app_name/react_io.ex
has these contents:This is because of Elixir's new stricter checks on variable re-binding inside conditionals.
This PR extracts the logic to add the reloader spec in a separate function, to improve the organization of the
init/1
function and to silence the "unsafe variable assignment" warnings.