-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalise restructure #875
base: main
Are you sure you want to change the base?
Finalise restructure #875
Conversation
Redirects 🔀Hey, @robertjdominguez & @seanparkross — the following redirects will be needed for deployment:
|
DX: Assertion Testing❌ DiffThe PR Diff shows a mass deletion of documentation files which, without any context or replacement, results in a loss of critical information about key features and guides (such as Federation and CI/CD). It removes the 'Architecture', 'Collaboration', and 'Federation' categories completely. This is not conducive to enhancing the usability of the documentation, as it strips away information without any indication of replication elsewhere or restructuring for improved clarity or cohesion. ❌ IntegratedThe integration of this PR would significantly reduce the usability of the documentation. The removal of entire categories and crucial tutorials (such as onboarding teams and best practices), without apparent replacement or reorganization, will leave users without guidance. This disrupts the documentation's comprehensiveness and accessibility, making it challenging for users to find necessary information on Hasura DDN's architecture, collaboration features, and data federation capabilities, as well as potentially creating broken links and a disjointed user experience. |
@seanparkross Thanks for your PR! I've assigned @robertjdominguez to review it. |
Deploying ddn-docs with
|
Latest commit: |
0a7067b
|
Status: | ✅ Deploy successful! |
Preview URL: | https://859ce558.v3-docs-eny.pages.dev |
Branch Preview URL: | https://sean-doc-2403-finalise-restr.v3-docs-eny.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mate, I think this is a great reorganization and a much cleaner sidebar. Well done 🎉
Description 📝
Collaboration
•
collaboration/service-accounts.mdx
=> ➡️ file moved toproject-configuration/project-management/service-accounts.mdx
•
collaboration/best-practices.mdx
=> ❌ deleted. Develop, Review, Deploy is already covered in other sections.•
collaboration/comment.mdx
=> ➡️ file moved toproject-configuration/project-management/console-collaborator-comments.mdx
•
collaboration/federation.mdx
=> ❌ deleted. Covered inproject-configuration/subgraphs/
• Collaboration section => ❌ deleted
Federation
•
federation/basics.mdx
=> ❌ deleted. Information covered inproject-configuration/*
•
federation/architecture.mdx
=> ❌ deleted and ➡️ info moved to enhance Glossary and FAQ•
federation/subgraph-prefixing
=> ➡️ file moved toproject-configuration/subgraphs/*
•
federation/build-commands
=> ❌ deleted. Information covered elsewhere•
federation/cross-repo-relationships
=> ❌ deleted and ➡️ info moved toproject-configuration/subgraphs/working-with-multiple-subgraphs.mdx
•
federation/independent-subgraph-development
=> ❌ deleted and ➡️ Information moved to/project-configuration/subgraphs/working-with-multiple-subgraphs.mdx
and/project-configuration/subgraphs/working-with-multiple-repositories.mdx
• Federation section => ❌ deleted
Upgrade
• Upgrade section ⬇️ moved down and renamed "Upgrade from v2"
Architecture
•
architecture/private/ byoc.mdx + dedicated.mdx + self-hosted.mdx
=> ➡️ files moved toprivate-ddn/architecture/*
•
architecture/topology.mdx +overview.mdx
=> ❌ deleted and ➡️ info moved to/reference/ddn-topology-architecture.mdx
• Architecture section => ❌ deleted
Quick Links 🚀
Many. See above.