Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial SQL Server configuration docs #880

Merged
merged 12 commits into from
Feb 10, 2025
Merged

Initial SQL Server configuration docs #880

merged 12 commits into from
Feb 10, 2025

Conversation

pranshi06
Copy link
Contributor

@pranshi06 pranshi06 commented Feb 6, 2025 •
edited
Loading

Description 📝

Adds configuration documentation for the SQL Server connector

Quick Links 🚀

Assertion Tests 🤖

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 6, 2025 •
edited
Loading

DX: Assertion Testing

✅ Diff

The PR adds comprehensive documentation for configuring the SQL Server connector, including detailed explanations and examples for each section of the configuration. This information will significantly assist users in setting up and understanding the various components of the SQL Server connector. The inclusion of json examples for native queries, native mutations, aggregate functions, and comparison operators is especially helpful for visual learners.

✅ Integrated

The PR integrates well with the existing set of files in the documentation. It introduces a new SQL Server connector reference that maintains consistency with the structure established by other connectors. By updating the index.md to include a link to the new SQL Server subsection, it makes the SQL Server connector easily discoverable and accessible, thereby improving the overall usability of the documentation.

@hasura-bot
Copy link
Contributor

@pranshi06 Thanks for your PR! I've assigned @seanparkross to review it.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2025 •
edited
Loading

Deploying ddn-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81f8c5b
Status: ✅  Deploy successful!
Preview URL: https://a5c67a97.v3-docs-eny.pages.dev
Branch Preview URL: https://pranshi-docs-add-sqlserver-d.v3-docs-eny.pages.dev

View logs

@pranshi06 pranshi06 marked this pull request as ready for review February 7, 2025 15:54
robertjdominguez
robertjdominguez approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@robertjdominguez robertjdominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll hold on @codingkarthik's review since you added him to this one, @pranshi06 🙏

docs/reference/connectors/sqlserver/index.mdx Outdated Show resolved Hide resolved
docs/reference/connectors/sqlserver/index.mdx Outdated Show resolved Hide resolved
@pranshi06 pranshi06 enabled auto-merge (squash) February 10, 2025 07:22
@pranshi06 pranshi06 merged commit 91082ac into main Feb 10, 2025
3 of 4 checks passed
@pranshi06 pranshi06 deleted the pranshi/docs/add-sqlserver-docs branch February 10, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingkarthik codingkarthik codingkarthik approved these changes

@robertjdominguez robertjdominguez robertjdominguez approved these changes

@seanparkross seanparkross Awaiting requested review from seanparkross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranshi06 @hasura-bot @codingkarthik @robertjdominguez