-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic docs for the elasticsearch connector #886
Conversation
@m-Bilal Thanks for your PR! I've assigned @robertjdominguez to review it. |
DX: Assertion Testing✅ DiffThe PR provides a comprehensive guide for integrating Hasura DDN with Elasticsearch, covering authentication, project setup, Elasticsearch container initialization, and querying. It's well-structured with descriptive subheadings and clear code snippets. However, please make sure that all CLI commands used are compatible with the current system configurations and are tested to work as intended. ✅ IntegratedThe documentation integrates well with the existing structure, maintaining consistency in format and style. The addition respects the sidebar positioning and keywords, ensuring the new content fits smoothly into the navigation flow. Updating the 'with-others.mdx' file's sidebar position ensures there are no conflicts or overlaps, keeping the documentation organized. Just ensure proper linking to the relevant sections and documentation for continuity and ease of navigation. |
Deploying ddn-docs with
|
Latest commit: |
536dbd0
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d56cff83.v3-docs-eny.pages.dev |
Branch Preview URL: | https://m-bilal-docs-elasticsearch-b.v3-docs-eny.pages.dev |
@@ -1,5 +1,5 @@ | |||
--- | |||
sidebar_position: 6 | |||
sidebar_position: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DBs in this section were not sorted alphabetically. For now, I just made elastic position 6 and moved this to position 7. Let me know please @robertjdominguez if that's okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we can alphabetize in a follow-up 👍
Bumping this as you have is perfect for now.
Relationship docs not added due to this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,5 +1,5 @@ | |||
--- | |||
sidebar_position: 6 | |||
sidebar_position: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we can alphabetize in a follow-up 👍
Bumping this as you have is perfect for now.
Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io>
I'm not sure. You can inform him if things look good to you, and he can tell you whether or not he'd like to take a look as well. Thanks for the quick review @robertjdominguez ! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description 📝
The following docs have been added for the Elasticsearch Connector
Quick Links 🚀
Assertion Tests 🤖