fix order_by case sensitivity

hasura · Jun 7, 2024 · 4a416a2 · 4a416a2
1 parent 84e2fd7
commit 4a416a2
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,9 @@
 # DuckDB Connector Changelog
 This changelog documents changes between release tags.
 
+## [0.0.16] - 2024-05-6
+* Change orderBy to use default casing. (Ordering is case-sensitive and uses underlying implementation which differs from Postgres)
+
 ## [0.0.15] - 2024-05-6
 * Remove linux/arm/v7 from platforms
 

diff --git a/connector-definition/connector-metadata.yaml b/connector-definition/connector-metadata.yaml
@@ -1,13 +1,13 @@
 packagingDefinition:
   type: PrebuiltDockerImage
-  dockerImage: ghcr.io/hasura/ndc-duckdb:v0.0.15
+  dockerImage: ghcr.io/hasura/ndc-duckdb:v0.0.16
 supportedEnvironmentVariables:
   - name: DUCKDB_URL
     description: The url for the DuckDB database
 commands:
   update:
     type: Dockerized
-    dockerImage: ghcr.io/hasura/ndc-duckdb:v0.0.15
+    dockerImage: ghcr.io/hasura/ndc-duckdb:v0.0.16
     commandArgs:
       - update
 dockerComposeWatch:

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "duckdb-sdk",
-  "version": "0.0.15",
+  "version": "0.0.16",
   "description": "",
   "main": "index.js",
   "scripts": {

diff --git a/src/handlers/query.ts b/src/handlers/query.ts
@@ -328,7 +328,7 @@ function build_query(
               currentAlias = nextAlias;
             }
             order_elems.push(
-              `LOWER(${escape_double(currentAlias)}.${escape_double(elem.target.name)}) ${elem.order_direction}`
+              `${escape_double(currentAlias)}.${escape_double(elem.target.name)} ${elem.order_direction}`
             );
           }
           break;