CLI plugin #1
Merged
CLI plugin #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix configuration for CLI plugin
hallettj
approved these changes
Mar 15, 2024
| futures-util = "0.3.28" | ||
| indexmap = { version = "1", features = ["serde"] } # must match the version that ndc-client uses | ||
| serde = { version = "1.0", features = ["derive"] } | ||
| serde_json = { version = "1.0.113", features = ["raw_value"] } |
There was a problem hiding this comment.
Something I often ask people to do is not to set exact dependency versions in Cargo.toml - that's what Cargo.lock is for. But it's less of a problem in a program vs a library.
crates/mongodb-connector/src/lib.rs
Outdated
| @@ -0,0 +1,5 @@ | |||
| pub mod api_type_conversions; | |||
There was a problem hiding this comment.
It looks like maybe you added this file so you could import mongodb-connector in the cli, but then decided not to, and forgot to delete this file?
There was a problem hiding this comment.
Yes, that's what happened. I'll delete the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a new
clicrate with an executable designed to be used as a Hasura CLI connector plugin.Currently the cli plugin provides a single command
update, which uses the validation schema from each collection (if there is one) to derive types and write a schema file that can be used by the MongoDB Connector.Issue ticket number and link
https://hasurahq.atlassian.net/browse/MDB-12
Type
(Select only one. In case of multiple, choose the most appropriate)