prune superfluous inferred object types from native query configuration #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codedmart
reviewed
Nov 11, 2024
| return (Cow::Borrowed(name), 0); | ||
| }; | ||
| (Cow::Owned(prefix.to_string()), count) | ||
| } |
There was a problem hiding this comment.
So a suffix only gets added if there is more then one? Or does this not really matter because the prune fns below remove these?
There was a problem hiding this comment.
Yes, the suffix is only added if the count is 1 or higher. And then the prune step attempts to remove the suffix if that wouldn't cause a collision, but otherwise uses the lowest-number suffix that doesn't cause a collision after pruning.
codedmart
approved these changes
Nov 11, 2024
…ct-types-when-generating-native-query
hallettj
deleted the
jessehallett/eng-1098-prune-unnecessary-object-types-when-generating-native-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.