Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration for native queries #3

Merged
merged 8 commits into from
Mar 15, 2024
Merged

configuration for native queries #3

merged 8 commits into from
Mar 15, 2024

Conversation

hallettj
Copy link
Collaborator

Adds configuration for native queries, and includes native queries in schema response. Does not implement native queries in the query handler.

This changes the way the configuration directory is read:

  • schema.{json,yaml,yml} is parsed according to configuration::Schema
  • all json and yaml files in the native_queries subdirectory are parsed according to configuration::native_queries::NativeQuery, and are combined into a Vec
  • the configuration::read_directory function combines the above results into one configuration::Configuration value

According to Rikin's feedback I changed the name of the configuration::Metadata type to configuration::Schema.

https://hasurahq.atlassian.net/browse/MDB-21

Copy link
Contributor

@dmoverton dmoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hallettj hallettj merged commit f4e42fa into main Mar 15, 2024
2 checks passed
@hallettj hallettj deleted the jesse/native-queries branch March 15, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants