mutations via native queries #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
requested review from
codedmart,
sordina,
daniel-chambers and
dmoverton
dmoverton
reviewed
Mar 20, 2024
| let native_query = config | ||
| .native_queries | ||
| .iter() | ||
| .find(|native_query| native_query.name == name); |
There was a problem hiding this comment.
See my comment on PR #5. We will want a more performant way to look up native queries than linear search. This is within a map now so potentially O(m * n) where m is the number of operations and n is the number of native queries.
There was a problem hiding this comment.
Good point, I filed https://hasurahq.atlassian.net/browse/MDB-91 to follow up
dmoverton
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a mutation endpoint to run procedures. I added an example native query to fixtures,
insertArtist, to demonstrate.I'll follow up with another PR that implements arguments to native queries where I'll replace the hard-coded inputs.
I'm having a problem querying the
Artistcollection which I think is unrelated, but I'm going to check that out and likely submit a bug fix PR. I confirmed thatinsertArtistdoes update the database correctly, and I wanted to get this PR out.Ticket: https://hasurahq.atlassian.net/browse/MDB-86