Fixed functions that are imported then re-exported causing a crash #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-chambers
changed the title
sordina
approved these changes
Apr 10, 2024
| @@ -7,6 +7,8 @@ This changelog documents the changes between release versions. | |||
| ## [Unreleased] | |||
| Changes to be included in the next upcoming release | |||
|
|
|||
| - Fixed functions that are imported then re-exported causing a crash [#28](https://github.com/hasura/ndc-nodejs-lambda/pull/28) | |||
Comment on lines
+178
to
+181
| const exportTargetDeclaration = | ||
| exportTarget.valueDeclaration // 'export { name } from "./imported"' | ||
| ?? typeChecker.getAliasedSymbol(exportTarget).valueDeclaration // 'import { name } from "./imported"; export { name }' | ||
| ?? throwError("export target symbol does not have a value declaration"); |
Comment on lines
+1
to
+8
| import { fileAChildFunction as renamedFileAChildFunction } from "./file-a" | ||
| import { fileBChildFunction1, fileBChildFunction2 } from "./file-b" | ||
|
|
||
| export { | ||
| renamedFileAChildFunction, | ||
| fileBChildFunction1, | ||
| fileBChildFunction2 as renamedFileBChildFunction2 | ||
| }; |
| @@ -206,4 +206,65 @@ describe("re-exported functions", function() { | |||
| } | |||
| }) | |||
| }); | |||
|
|
|||
| it("supports re-exports of functions from other files that are first imported then exported", function() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where if one was to re-export functions from another file like so:
you would cause the type inference to crash. This PR fixes the type inference so it correctly handles this corner case by following the import symbol's alias to its source then getting its declaration.