Make mutation pre/post checks optional #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub table_name: sql::ast::TableName, | ||
| pub by_columns: NonEmpty<metadata::database::ColumnInfo>, | ||
| pub columns_prefix: String, | ||
| pub pre_check: Option<CheckArgument>, |
There was a problem hiding this comment.
The Option here isn't necessary, this can be CheckArgument.
There was a problem hiding this comment.
(it's optional that the user provides the argument, but the argument will always be in the schema, just nullable)
| @@ -24,7 +24,7 @@ pub struct InsertMutation { | |||
| pub table_name: sql::ast::TableName, | |||
| pub objects_argument_name: models::ArgumentName, | |||
| pub columns: BTreeMap<models::FieldName, metadata::database::ColumnInfo>, | |||
| pub post_check: CheckArgument, | |||
| pub post_check: Option<CheckArgument>, | |||
There was a problem hiding this comment.
The Option here isn't necessary, this can be CheckArgument.
| @@ -32,18 +32,11 @@ pub struct UpdateByKey { | |||
| pub by_columns: NonEmpty<metadata::database::ColumnInfo>, | |||
| pub columns_prefix: String, | |||
| pub update_columns_argument_name: models::ArgumentName, | |||
| pub pre_check: Constraint, | |||
| pub post_check: Constraint, | |||
| pub pre_check: Option<CheckArgument>, | |||
There was a problem hiding this comment.
Both the Options here aren't necessary, they can be CheckArgument.
| let post_predicate_json = | ||
| mutation.post_check | ||
| .as_ref() | ||
| .and_then(|post_check| arguments.get(&post_check.argument_name)) |
danieljharvey
force-pushed
the
codedmart/postgres-updates
branch
from
e1cdc15
to
379c281
Compare
danieljharvey
changed the title
danieljharvey
force-pushed
the
codedmart/postgres-updates
branch
from
01c2301
to
b3f1bd4
Compare
danieljharvey
approved these changes
Oct 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
<!-- The PR description should answer 2 (maybe 3) important questions: --> ### What Pulled from #635 into own PR. We add `mutations_prefix: Option<String>` to v5 configuration. When left `null` (for existing projects), we default to `v2_mutation_name`, but it can be replaced with `horse_mutation_name` etc. Most people will just want to use it to remove the prefix though, and that is the default for new projects. `mutationsPrefix: ""` will get rid of the prefix altogether, which I assume most users would want. ### How <!-- How is it trying to accomplish it (what are the implementation steps)? --> --------- Co-authored-by: Brandon Martin <brandon@codedmart.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What