Skip to content

fix: corrected vim.validate, documentation and improved StyLua#4

Merged
hat0uma merged 11 commits intohat0uma:mainfrom
DrKJeff16:patch/fixup
Sep 4, 2025
Merged

fix: corrected vim.validate, documentation and improved StyLua#4
hat0uma merged 11 commits intohat0uma:mainfrom
DrKJeff16:patch/fixup

Conversation

@DrKJeff16
Copy link
Contributor

@DrKJeff16 DrKJeff16 commented Sep 2, 2025

Changes

  • Corrected every call to vim.validate()
  • Expanded .stylua.toml (on a different commit, just in case)

Before

prelive_pr

After

prelive_pr2

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16 DrKJeff16 changed the title fix: corrected deprecated use of vim.validate fix: corrected deprecated use of vim.validate Sep 2, 2025
@DrKJeff16 DrKJeff16 changed the title fix: corrected deprecated use of vim.validate fix: corrected vim.validate calls and extended StyLua config Sep 2, 2025
@DrKJeff16
Copy link
Contributor Author

How did a workflow fail with this?

@hat0uma
Copy link
Owner

hat0uma commented Sep 3, 2025

Thanks for the PR!

The workflow is failing for Neovim 0.10.1 because this version doesn't support the new vim.validate syntax used in the PR.
In order to support both versions, would you be willing to make a change? It might be a bit clunky, but coulud we use a condition such as vim.fn.has('nvim-0.11') == 1 to switch between the old and new syntax?

@DrKJeff16
Copy link
Contributor Author

@hat0uma Then I shall add a dynamic validator, like in nvim-notify

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16
Copy link
Contributor Author

This commit is unrelated, I'm gonna start doing the rework.

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16
Copy link
Contributor Author

DrKJeff16 commented Sep 3, 2025

@hat0uma Done. Let me know if I missed anything.

I also fixed the uv_... types (my LSP was screaming warnings at me).

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16 DrKJeff16 changed the title fix: corrected vim.validate calls and extended StyLua config fix: corrected vim.validate, documentation and improved StyLua Sep 3, 2025
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16
Copy link
Contributor Author

Weird. Workflow is failing with the original vim.validate values...

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16
Copy link
Contributor Author

I'm dumb, fixing.

Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
@DrKJeff16
Copy link
Contributor Author

@hat0uma All should be good now!

@hat0uma hat0uma merged commit dd2c7c6 into hat0uma:main Sep 4, 2025
3 checks passed
@hat0uma
Copy link
Owner

hat0uma commented Sep 4, 2025

Many thanks!

@DrKJeff16 DrKJeff16 deleted the patch/fixup branch September 4, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants