Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmcloak init command uses obsolete argumets for genisoimage, mkisofs and qemu-system-x86_64 internaly #207

Closed
wants to merge 2 commits into from
Closed

vmcloak init command uses obsolete argumets for genisoimage, mkisofs and qemu-system-x86_64 internaly #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
587c2df
The argument "-allow-limited-size" was removed from both genisoimage …
Ankabi Dec 12, 2022
79f73a8
The "-soundhw" argument has been deprecated since version 5.1 of qemu…
Ankabi Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vmcloak/abstract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ class WindowsAutounattended(OperatingSystem):
dummy_serial_key = None
genisoargs = [
"-no-emul-boot", "-iso-level", "2", "-udf", "-J", "-l", "-D", "-N",
"-joliet-long", "-relaxed-filenames", "-allow-limited-size",
"-joliet-long", "-relaxed-filenames",
]

def _autounattend_xml(self, product, ipaddress, gateway):
Expand Down
6 changes: 4 additions & 2 deletions vmcloak/platforms/qemu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ def _make_pre_v41_args(attr):
"-device", "ide-cd,bus=ahci.1,unit=0,drive=cdrom,bootindex=1",
"-device", "usb-ehci,id=ehci",
"-device", "usb-tablet,bus=ehci.0",
"-soundhw", "hda",
"-device", "intel-hda",
"-device", "hda-duplex",
"--enable-kvm"
]

Expand All @@ -82,7 +83,8 @@ def _make_post_v41_args(attr):
"-device", "ide-cd,bus=ahci.1,unit=0,drive=cdrom,bootindex=1",
"-device", "usb-ehci,id=ehci",
"-device", "usb-tablet,bus=ehci.0",
"-soundhw", "hda",
"-device", "intel-hda",
"-device", "hda-duplex",
"-enable-kvm"
]

Expand Down