Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

fix: Ignore ready state validations for directories #73

Merged
merged 4 commits into from
Sep 29, 2023
Merged

fix: Ignore ready state validations for directories #73

merged 4 commits into from
Sep 29, 2023

Conversation

PedroChaparro
Copy link
Contributor

Includes:

  • Update endpoint to get metadata to skip ready checks for directories
  • Use a single query with a transaction to update the volume column in the files table and the ready column in the archives table.
  • Update query to get files shared with an user to skip ready checks for directories.

@PedroChaparro PedroChaparro added the bug Something isn't working label Sep 27, 2023
@PedroChaparro PedroChaparro self-assigned this Sep 27, 2023
Woynert
Woynert approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@Woynert Woynert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

@PedroChaparro PedroChaparro merged commit fa5467f into dev Sep 29, 2023
3 checks passed
@PedroChaparro PedroChaparro deleted the fix/#72_directories_ready_state branch September 29, 2023 11:26
PedroChaparro added a commit that referenced this pull request Oct 1, 2023
@PedroChaparro @shoriwe
release: v0.10.3 (#76)
e9ed34f 
* fix: Ignore ready state validations for directories (#73)

* fix: Skip directories ready check

* fix: Use transaction to update volume and ready columns

* fix: Update query to obtain files shared with an user

* test: Update tests

* fix: Parse null-able extension field (#75)

* refactor: Use same filename in ArchiveMeta class to fix warning

* ci: Run tests when a pull request is created to main

* style: Format files

---------

Co-authored-by: Antonio Donis <antoniojosedonishung@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Woynert Woynert Woynert approved these changes

Assignees

@PedroChaparro PedroChaparro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PedroChaparro @Woynert